public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit
Date: Fri, 23 Feb 2024 12:45:51 +0100	[thread overview]
Message-ID: <20240223114551.15392-1-h.laimer@proxmox.com> (raw)

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---

came up in enterprise support, and I don't think there is a reason to
not have it in the UI, while having it in the API

 www/manager6/storage/DirEdit.js | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
index 3e2025fc..52e7134b 100644
--- a/www/manager6/storage/DirEdit.js
+++ b/www/manager6/storage/DirEdit.js
@@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', {
 	    },
 	];
 
+	me.advancedColumn2 = [
+	    {
+		xtype: 'proxmoxcheckbox',
+		name: 'is_mountpoint',
+		uncheckedValue: 0,
+		fieldLabel: gettext('Mountpoint'),
+		autoEl: {
+		    tag: 'div',
+		    'data-qtip': gettext('Enable if something is mounted to this directory externally, storage is considered offline as long as nothing is mounted.'),
+		},
+	    },
+	];
 	me.callParent();
     },
 });
-- 
2.39.2





             reply	other threads:[~2024-02-23 11:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 11:45 Hannes Laimer [this message]
2024-02-23 11:51 ` Aaron Lauterer
2024-02-23 11:59   ` Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240223114551.15392-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal