public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-network 2/2] patches: allow ip|ip6-forward option on bridge
Date: Thu, 22 Feb 2024 15:28:30 +0100	[thread overview]
Message-ID: <20240222142830.2527837-3-aderumier@odiso.com> (raw)
In-Reply-To: <20240222142830.2527837-1-aderumier@odiso.com>

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
 debian/patches/series                         |  1 +
 ...dress-allow-ip-ip6-forward-on-bridge.patch | 32 +++++++++++++++++++
 2 files changed, 33 insertions(+)
 create mode 100644 debian/patches/upstream/0001-address-allow-ip-ip6-forward-on-bridge.patch

diff --git a/debian/patches/series b/debian/patches/series
index 557aa7f..3b80321 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -7,6 +7,7 @@ pve/0006-openvswitch-ovs-ports-condone-regex-exclude-tap-veth.patch
 pve/0007-allow-vlan-tag-inside-vxlan-tunnel.patch
 pve/0008-lacp-bond-remove-bond-min-links-0-warning.patch
 pve/0009-gvgeb-fix-python-interpreter-shebang.patch
+upstream/0001-address-allow-ip-ip6-forward-on-bridge.patch
 upstream/0001-add-ipv6-slaac-support-inet6-auto-accept_ra.patch
 upstream/0001-addons-ethtool-add-rx-vlan-filter.patch
 upstream/0001-scheduler-import-traceback.patch
diff --git a/debian/patches/upstream/0001-address-allow-ip-ip6-forward-on-bridge.patch b/debian/patches/upstream/0001-address-allow-ip-ip6-forward-on-bridge.patch
new file mode 100644
index 0000000..b61d891
--- /dev/null
+++ b/debian/patches/upstream/0001-address-allow-ip-ip6-forward-on-bridge.patch
@@ -0,0 +1,32 @@
+From cd21f46308052ae092d1036886cde2c3177e3642 Mon Sep 17 00:00:00 2001
+From: Alexandre Derumier <aderumier@gmail.com>
+Date: Thu, 22 Feb 2024 13:11:02 +0100
+Subject: [PATCH 2/2] address: allow ip|ip6-forward on bridge
+
+Currently, a bridge always have forward enabled if an ip exist,
+or disabled if not ip is present.
+
+we can't use ip-forward on|off to override it because of this return.
+
+Signed-off-by: Alexandre Derumier <aderumier@gmail.com>
+Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
+---
+ ifupdown2/addons/address.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/ifupdown2/addons/address.py b/ifupdown2/addons/address.py
+index bb5589e..7310646 100644
+--- a/ifupdown2/addons/address.py
++++ b/ifupdown2/addons/address.py
+@@ -984,7 +984,7 @@ class address(AddonWithIpBlackList, moduleBase):
+ 
+         if (ifaceobj.link_kind & ifaceLinkKind.BRIDGE):
+             self._set_bridge_forwarding(ifaceobj)
+-            return
++
+         if not self.syntax_check_sysctls(ifaceobj):
+             return
+         if not self.syntax_check_l3_svi_ip_forward(ifaceobj):
+-- 
+2.39.2
+
-- 
2.39.2




      parent reply	other threads:[~2024-02-22 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 14:28 [pve-devel] [PATCH pve-network 0/2] " Alexandre Derumier
2024-02-22 14:28 ` [pve-devel] [PATCH pve-network 1/2] patches: update slaac patch Alexandre Derumier
2024-02-22 14:28 ` Alexandre Derumier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222142830.2527837-3-aderumier@odiso.com \
    --to=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal