From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 5/5] cpu config: die on hotplug of non x86_64 CPUs
Date: Wed, 21 Feb 2024 15:33:17 +0100 [thread overview]
Message-ID: <20240221143317.134090-7-f.schauer@proxmox.com> (raw)
In-Reply-To: <20240221143317.134090-1-f.schauer@proxmox.com>
When attempting a CPU hotplug on an architecture other than x86_64, die
with a clean error instead of attempting a hotplug with a known
non-working device command line. Also move the corresponding FIXME up to
the error.
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
PVE/QemuServer/CPUConfig.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
index 7d471f4..01e4515 100644
--- a/PVE/QemuServer/CPUConfig.pm
+++ b/PVE/QemuServer/CPUConfig.pm
@@ -417,6 +417,9 @@ sub get_custom_model {
sub print_cpu_device {
my ($conf, $arch, $id) = @_;
+ # FIXME: hot plugging other architectures like our unofficial arch64 support?
+ die "Hotplug of non x86_64 CPU not yet supported" if $arch != 'x86_64';
+
my $kvm = $conf->{kvm} // is_native_arch($arch);
my $cpu = get_default_cpu_type('x86_64', $kvm);
if (my $cputype = $conf->{cpu}) {
@@ -441,7 +444,6 @@ sub print_cpu_device {
my $current_core = ($id - 1) % $cores;
my $current_socket = int(($id - 1 - $current_core)/$cores);
- # FIXME: hot plugging other architectures like our unofficial arch64 support?
return "$cpu-x86_64-cpu,id=cpu$id,socket-id=$current_socket,core-id=$current_core,thread-id=0";
}
--
2.39.2
next prev parent reply other threads:[~2024-02-21 14:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 14:33 [pve-devel] [PATCH-SERIES v8 qemu-server, common] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH common 1/1] tools: add is_native_arch to compare the CPU architecture Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH qemu-server 1/5] cpu config: add helper to get the default CPU type Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH qemu-server 2/5] prevent starting a 32-bit VM using a 64-bit OVMF BIOS Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH qemu-server 3/5] Move is_native from PVE::QemuServer to PVE::Tools Filip Schauer
2024-02-21 14:33 ` [pve-devel] [PATCH qemu-server 4/5] Unify the default value for 'kvm' Filip Schauer
2024-02-23 11:54 ` Filip Schauer
2024-02-21 14:33 ` Filip Schauer [this message]
2024-03-08 13:34 ` [pve-devel] [PATCH qemu-server 5/5] cpu config: die on hotplug of non x86_64 CPUs Thomas Lamprecht
2024-03-08 13:53 ` Fiona Ebner
2024-03-11 10:13 ` Filip Schauer
2024-03-08 13:34 ` [pve-devel] partially-applied-series: [PATCH-SERIES v8 qemu-server, common] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221143317.134090-7-f.schauer@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox