[pve-devel] [PATCH manager v2] fix #5251: login: set autocomplete on password and user

[pve-devel] [PATCH manager v2] fix #5251: login: set autocomplete on password and user

[Maximiliano Sandoval]

By default they have 'autocomplete=off'. From [1]:

 > In most modern browsers, setting autocomplete to "off" will not
 > prevent a password manager from asking the user if they would like to
 > save username and password information, or from automatically filling
 > in those values in a site's login form. See the autocomplete
 > attribute and login fields [2].

[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
[2] https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#the_autocomplete_attribute_and_login_fields

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v1:
 - Learn how to send emails
 - Fix 'fix #5251' prefix in commit titles

 www/manager6/window/LoginWindow.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/window/LoginWindow.js b/www/manager6/window/LoginWindow.js
index a79f5a2a..aaeca355 100644
--- a/www/manager6/window/LoginWindow.js
+++ b/www/manager6/window/LoginWindow.js
@@ -344,6 +344,7 @@ Ext.define('PVE.window.LoginWindow', {
 		itemId: 'usernameField',
 		reference: 'usernameField',
 		stateId: 'login-username',
+		inputAttrTpl: 'autocomplete=username',
 		bind: {
 		    visible: "{!openid}",
 		    disabled: "{openid}",
@@ -355,6 +356,7 @@ Ext.define('PVE.window.LoginWindow', {
 		fieldLabel: gettext('Password'),
 		name: 'password',
 		reference: 'passwordField',
+		inputAttrTpl: 'autocomplete=current-password',
 		bind: {
 		    visible: "{!openid}",
 		    disabled: "{openid}",
-- 
2.39.2

[pve-devel] [PATCH widget-toolkit v2] fix #5251: tfa: set autocomplete on tfa input form

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/window/TfaWindow.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/window/TfaWindow.js b/src/window/TfaWindow.js
index 3646e0e..7c6f2ee 100644
--- a/src/window/TfaWindow.js
+++ b/src/window/TfaWindow.js
@@ -374,6 +374,7 @@ Ext.define('Proxmox.window.TfaLoginWindow', {
 			allowBlank: false,
 			regex: /^[0-9]{2,16}$/,
 			regexText: gettext('TOTP codes usually consist of six decimal digits'),
+			inputAttrTpl: 'autocomplete=one-time-code',
 		    },
 		],
 	    },
-- 
2.39.2

[pve-devel] [PATCH backup v2] fix #5251: login: set autocomplete on password and user

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/LoginView.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/LoginView.js b/www/LoginView.js
index 33734f6c..d4d8e73e 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -274,6 +274,7 @@ Ext.define('PBS.LoginView', {
 			    itemId: 'usernameField',
 			    reference: 'usernameField',
 			    stateId: 'login-username',
+			    inputAttrTpl: 'autocomplete=username',
 			    bind: {
 				visible: "{!openid}",
 				disabled: "{openid}",
@@ -286,6 +287,7 @@ Ext.define('PBS.LoginView', {
 			    name: 'password',
 			    itemId: 'passwordField',
 			    reference: 'passwordField',
+			    inputAttrTpl: 'autocomplete=current-password',
 			    bind: {
 				visible: "{!openid}",
 				disabled: "{openid}",
-- 
2.39.2

[pve-devel] [PATCH pmg-gui v2] fix #5251: login: set autocomplete on password and user

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 js/LoginView.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/js/LoginView.js b/js/LoginView.js
index 63f4099..b5da19a 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -249,6 +249,7 @@ Ext.define('PMG.LoginView', {
 			    itemId: 'usernameField',
 			    reference: 'usernameField',
 			    stateId: 'login-username',
+			    inputAttrTpl: 'autocomplete=username',
 			},
 			{
 			    xtype: 'textfield',
@@ -256,6 +257,7 @@ Ext.define('PMG.LoginView', {
 			    fieldLabel: gettext('Password'),
 			    name: 'password',
 			    reference: 'passwordField',
+			    inputAttrTpl: 'autocomplete=current-password',
 			},
 			{
 			    xtype: 'proxmoxLanguageSelector',
-- 
2.39.2

[pve-devel] applied-series: [PATCH manager v2] fix #5251: login: set autocomplete on password and user

[Thomas Lamprecht]

Am 19/02/2024 um 11:37 schrieb Maximiliano Sandoval:
> By default they have 'autocomplete=off'. From [1]:
> 
>  > In most modern browsers, setting autocomplete to "off" will not
>  > prevent a password manager from asking the user if they would like to
>  > save username and password information, or from automatically filling
>  > in those values in a site's login form. See the autocomplete
>  > attribute and login fields [2].
> 
> [1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
> [2] https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#the_autocomplete_attribute_and_login_fields
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Differences from v1:
>  - Learn how to send emails
>  - Fix 'fix #5251' prefix in commit titles
> 
>  www/manager6/window/LoginWindow.js | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied series, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel