public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] fix-5251: login: set autocomplete on password and user
@ 2024-02-19 10:24 Maximiliano Sandoval
  2024-02-19 10:24 ` [pve-devel] [PATCH widget-toolkit] fix-5251: tfa: set autocomplete on tfa input form Maximiliano Sandoval
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Maximiliano Sandoval @ 2024-02-19 10:24 UTC (permalink / raw)
  To: pve-devel

By default they have 'autocomplete=off'. From [1]:

 > In most modern browsers, setting autocomplete to "off" will not
 > prevent a password manager from asking the user if they would like to
 > save username and password information, or from automatically filling
 > in those values in a site's login form. See the autocomplete
 > attribute and login fields [2].

[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
[2] https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#the_autocomplete_attribute_and_login_fields

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/window/LoginWindow.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/window/LoginWindow.js b/www/manager6/window/LoginWindow.js
index a79f5a2a..aaeca355 100644
--- a/www/manager6/window/LoginWindow.js
+++ b/www/manager6/window/LoginWindow.js
@@ -344,6 +344,7 @@ Ext.define('PVE.window.LoginWindow', {
 		itemId: 'usernameField',
 		reference: 'usernameField',
 		stateId: 'login-username',
+		inputAttrTpl: 'autocomplete=username',
 		bind: {
 		    visible: "{!openid}",
 		    disabled: "{openid}",
@@ -355,6 +356,7 @@ Ext.define('PVE.window.LoginWindow', {
 		fieldLabel: gettext('Password'),
 		name: 'password',
 		reference: 'passwordField',
+		inputAttrTpl: 'autocomplete=current-password',
 		bind: {
 		    visible: "{!openid}",
 		    disabled: "{openid}",
-- 
2.39.2





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-02-19 10:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-19 10:24 [pve-devel] [PATCH manager] fix-5251: login: set autocomplete on password and user Maximiliano Sandoval
2024-02-19 10:24 ` [pve-devel] [PATCH widget-toolkit] fix-5251: tfa: set autocomplete on tfa input form Maximiliano Sandoval
2024-02-19 10:24 ` [pve-devel] [PATCH backup] fix-5251: login: set autocomplete on password and user Maximiliano Sandoval
2024-02-19 10:24 ` [pve-devel] [PATCH pmg-gui] " Maximiliano Sandoval
2024-02-19 10:34 ` [pve-devel] [PATCH manager] " Maximiliano Sandoval

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal