public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix-5251: login: set autocomplete on password and user
Date: Mon, 19 Feb 2024 11:24:50 +0100	[thread overview]
Message-ID: <20240219102453.240492-1-m.sandoval@proxmox.com> (raw)

By default they have 'autocomplete=off'. From [1]:

 > In most modern browsers, setting autocomplete to "off" will not
 > prevent a password manager from asking the user if they would like to
 > save username and password information, or from automatically filling
 > in those values in a site's login form. See the autocomplete
 > attribute and login fields [2].

[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
[2] https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#the_autocomplete_attribute_and_login_fields

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/window/LoginWindow.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/window/LoginWindow.js b/www/manager6/window/LoginWindow.js
index a79f5a2a..aaeca355 100644
--- a/www/manager6/window/LoginWindow.js
+++ b/www/manager6/window/LoginWindow.js
@@ -344,6 +344,7 @@ Ext.define('PVE.window.LoginWindow', {
 		itemId: 'usernameField',
 		reference: 'usernameField',
 		stateId: 'login-username',
+		inputAttrTpl: 'autocomplete=username',
 		bind: {
 		    visible: "{!openid}",
 		    disabled: "{openid}",
@@ -355,6 +356,7 @@ Ext.define('PVE.window.LoginWindow', {
 		fieldLabel: gettext('Password'),
 		name: 'password',
 		reference: 'passwordField',
+		inputAttrTpl: 'autocomplete=current-password',
 		bind: {
 		    visible: "{!openid}",
 		    disabled: "{openid}",
-- 
2.39.2





             reply	other threads:[~2024-02-19 10:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 10:24 Maximiliano Sandoval [this message]
2024-02-19 10:24 ` [pve-devel] [PATCH widget-toolkit] fix-5251: tfa: set autocomplete on tfa input form Maximiliano Sandoval
2024-02-19 10:24 ` [pve-devel] [PATCH backup] fix-5251: login: set autocomplete on password and user Maximiliano Sandoval
2024-02-19 10:24 ` [pve-devel] [PATCH pmg-gui] " Maximiliano Sandoval
2024-02-19 10:34 ` [pve-devel] [PATCH manager] " Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240219102453.240492-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal