From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v3 05/19] ui: dc: backup: allow to set custom job id in advanced settings
Date: Fri, 16 Feb 2024 10:15:54 +0100 [thread overview]
Message-ID: <20240216091608.60317-6-l.wagner@proxmox.com> (raw)
In-Reply-To: <20240216091608.60317-1-l.wagner@proxmox.com>
This might be useful if somebody wants to match on the new
'backup-job' field in a notification match rule.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/Utils.js | 4 ++++
www/manager6/dc/Backup.js | 11 +++++++++++
2 files changed, 15 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index a8d5786d..4c8bf9d3 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1942,6 +1942,10 @@ Ext.define('PVE.Utils', {
singleton: true,
constructor: function() {
var me = this;
+
+ // Same regex as 'pve-configid
+ me.CONFIGID_RE = /^[A-Za-z][A-Za-z0-9_-]+$/;
+
Ext.apply(me, me.utilities);
Proxmox.Utils.override_task_descriptions({
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index fb4df0a7..c87f780d 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -397,6 +397,17 @@ Ext.define('PVE.dc.BackupEdit', {
},
],
advancedColumn1: [
+ {
+ xtype: 'pmxDisplayEditField',
+ fieldLabel: gettext('Job ID'),
+ emptyText: gettext('Autogenerate'),
+ name: 'id',
+ allowBlank: true,
+ regex: PVE.Utils.CONFIGID_RE,
+ cbind: {
+ editable: '{isCreate}',
+ },
+ },
{
xtype: 'proxmoxcheckbox',
fieldLabel: gettext('Repeat missed'),
--
2.39.2
next prev parent reply other threads:[~2024-02-16 9:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 9:15 [pve-devel] [PATCH manager/widget-toolkit/docs v3 00/19] notifications: notification metadata matching improvements Lukas Wagner
2024-02-16 9:15 ` [pve-devel] [PATCH manager v3 01/19] api: notifications: add 'smtp' to target index Lukas Wagner
2024-02-16 9:15 ` [pve-devel] [PATCH manager v3 02/19] api: jobs: vzdump: pass job 'id' parameter Lukas Wagner
2024-02-16 9:15 ` [pve-devel] [PATCH manager v3 03/19] ui: dc: backup: send 'id' property when starting a backup job manually Lukas Wagner
2024-02-16 9:15 ` [pve-devel] [PATCH manager v3 04/19] ui: dc: backup: show 'Job ID' column Lukas Wagner
2024-02-20 15:23 ` Thomas Lamprecht
2024-02-20 15:38 ` Lukas Wagner
2024-02-20 16:26 ` Thomas Lamprecht
2024-02-23 13:46 ` Thomas Lamprecht
2024-02-16 9:15 ` Lukas Wagner [this message]
2024-02-16 9:15 ` [pve-devel] [PATCH manager v3 06/19] api: replication: add 'replication-job' to notification metadata Lukas Wagner
2024-02-16 9:15 ` [pve-devel] [PATCH manager v3 07/19] ui: replication: show 'Job ID' column Lukas Wagner
2024-02-16 9:15 ` [pve-devel] [PATCH manager v3 08/19] vzdump: apt: notification: do not include domain in 'hostname' field Lukas Wagner
2024-02-16 9:15 ` [pve-devel] [PATCH manager v3 09/19] api: replication: include 'hostname' field for notifications Lukas Wagner
2024-02-16 9:15 ` [pve-devel] [PATCH manager v3 10/19] api: notification: add API for getting known metadata fields/values Lukas Wagner
2024-02-16 9:16 ` [pve-devel] [PATCH manager v3 11/19] ui: utils: add overrides for translatable notification fields/values Lukas Wagner
2024-02-16 9:16 ` [pve-devel] [PATCH widget-toolkit v3 12/19] combogrid: add 'showClearTrigger' config Lukas Wagner
2024-02-16 9:16 ` [pve-devel] [PATCH widget-toolkit v3 13/19] notification: matcher: match-field: show known fields/values Lukas Wagner
2024-02-16 9:16 ` [pve-devel] [PATCH widget-toolkit v3 14/19] notification: matcher: move match-field formulas to local viewModel Lukas Wagner
2024-02-16 9:16 ` [pve-devel] [PATCH widget-toolkit v3 15/19] notification: matcher: move match-calendar fields to panel Lukas Wagner
2024-02-16 9:16 ` [pve-devel] [PATCH widget-toolkit v3 16/19] notification: matcher: move match-severity " Lukas Wagner
2024-02-16 9:16 ` [pve-devel] [PATCH docs v3 17/19] notification: clarify that 'hostname' does not include the domain Lukas Wagner
2024-02-16 9:16 ` [pve-devel] [PATCH docs v3 18/19] notifications: describe new notification metadata fields Lukas Wagner
2024-02-16 9:16 ` [pve-devel] [PATCH docs v3 19/19] notifications: match-field 'exact'-mode can now match multiple values Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216091608.60317-6-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox