* [pve-devel] [PATCH pve-manager] sdn: evpn: allow empty primary exit node in zone form
@ 2024-02-13 10:40 Alexandre Derumier
2024-02-22 16:42 ` Stefan Hanreich
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Derumier @ 2024-02-13 10:40 UTC (permalink / raw)
To: pve-devel
It's broken since
https://git.proxmox.com/?p=pve-network.git;a=commit;h=3e3cafabaf955d53c4c2d4e346bf5c3a5c6d1852
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
www/manager6/sdn/zones/EvpnEdit.js | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/www/manager6/sdn/zones/EvpnEdit.js b/www/manager6/sdn/zones/EvpnEdit.js
index a08faef2..2e792322 100644
--- a/www/manager6/sdn/zones/EvpnEdit.js
+++ b/www/manager6/sdn/zones/EvpnEdit.js
@@ -10,6 +10,11 @@ Ext.define('PVE.sdn.zones.EvpnInputPanel', {
values.type = me.type;
}
+ if (values['exitnodes-primary'] === '') {
+ delete values['exitnodes-primary'];
+ values.delete.push('exitnodes-primary');
+ }
+
return values;
},
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pve-devel] [PATCH pve-manager] sdn: evpn: allow empty primary exit node in zone form
2024-02-13 10:40 [pve-devel] [PATCH pve-manager] sdn: evpn: allow empty primary exit node in zone form Alexandre Derumier
@ 2024-02-22 16:42 ` Stefan Hanreich
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hanreich @ 2024-02-22 16:42 UTC (permalink / raw)
To: pve-devel
This was broken when adding a new EVPN zone and there's an easier way
built-in to our widget toolkit. I've taken the liberty of sending a v2
and mentioning you [1].
[1] https://lists.proxmox.com/pipermail/pve-devel/2024-February/061924.html
On 2/13/24 11:40, Alexandre Derumier wrote:
> It's broken since
> https://git.proxmox.com/?p=pve-network.git;a=commit;h=3e3cafabaf955d53c4c2d4e346bf5c3a5c6d1852
>
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
> www/manager6/sdn/zones/EvpnEdit.js | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/www/manager6/sdn/zones/EvpnEdit.js b/www/manager6/sdn/zones/EvpnEdit.js
> index a08faef2..2e792322 100644
> --- a/www/manager6/sdn/zones/EvpnEdit.js
> +++ b/www/manager6/sdn/zones/EvpnEdit.js
> @@ -10,6 +10,11 @@ Ext.define('PVE.sdn.zones.EvpnInputPanel', {
> values.type = me.type;
> }
>
> + if (values['exitnodes-primary'] === '') {
> + delete values['exitnodes-primary'];
> + values.delete.push('exitnodes-primary');
> + }
> +
> return values;
> },
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-22 16:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-13 10:40 [pve-devel] [PATCH pve-manager] sdn: evpn: allow empty primary exit node in zone form Alexandre Derumier
2024-02-22 16:42 ` Stefan Hanreich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox