From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 common] REST environment: warn helpers: also log messages to syslog
Date: Fri, 9 Feb 2024 15:15:03 +0100 [thread overview]
Message-ID: <20240209141503.62402-1-f.ebner@proxmox.com> (raw)
for better visibility. When not in a task, warnings from these helpers
are only logged to STDERR, which is particularly unhelpful in case of
daemons. This is the main motivation behind this change.
For tasks, warnings from these helpers are already more visible on the
UI side, but when looking at the syslog, one can only see the warning
count from the task right now, not the actual messages. This is
another reason in favor of the change.
Reported-by: Friedrich Weber <f.weber@proxmox.com>
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Changes in v2:
* Go with the approach suggested by Thomas.
src/PVE/RESTEnvironment.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm
index 191c6eb..bfde7e6 100644
--- a/src/PVE/RESTEnvironment.pm
+++ b/src/PVE/RESTEnvironment.pm
@@ -723,6 +723,7 @@ sub log_warn {
$rest_env->warn($message);
} else {
chomp($message);
+ syslog('warning', "%s", $message);
print STDERR "WARN: $message\n";
}
}
@@ -732,6 +733,7 @@ sub warn {
chomp($message);
+ syslog('warning', "%s", $message);
print STDERR "WARN: $message\n";
$self->{warning_count}++;
--
2.39.2
next reply other threads:[~2024-02-09 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 14:15 Fiona Ebner [this message]
2024-06-12 9:51 ` Fiona Ebner
2024-09-11 11:46 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209141503.62402-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox