From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/3] ui: user edit: protect user's TFA settings again
Date: Fri, 9 Feb 2024 14:08:19 +0100 [thread overview]
Message-ID: <20240209130821.51461-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20240209130821.51461-1-f.ebner@proxmox.com>
Same rationale as in 5b25580d ("Protect the user's tfa key setting."):
it should not be possible to change the value when it's not an actual
secret but a reference to what TFA method is used or, in case of 'x',
whether TFA is used.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
www/manager6/dc/UserEdit.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/www/manager6/dc/UserEdit.js b/www/manager6/dc/UserEdit.js
index b637cd53..ad52edf0 100644
--- a/www/manager6/dc/UserEdit.js
+++ b/www/manager6/dc/UserEdit.js
@@ -162,7 +162,10 @@ Ext.define('PVE.dc.UserEdit', {
var data = response.result.data;
me.setValues(data);
if (data.keys) {
- if (data.keys === 'x!oath' || data.keys === 'x!u2f') {
+ if (data.keys === 'x' ||
+ data.keys === 'x!oath' ||
+ data.keys === 'x!u2f' ||
+ data.keys === 'x!yubico') {
me.down('[name="keys"]').setDisabled(1);
}
}
--
2.39.2
next prev parent reply other threads:[~2024-02-09 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 13:08 [pve-devel] [PATCH-SERIES manager] ui: user edit: improve 'keys' field Fiona Ebner
2024-02-09 13:08 ` Fiona Ebner [this message]
2024-04-23 14:52 ` [pve-devel] applied: [PATCH manager 1/3] ui: user edit: protect user's TFA settings again Thomas Lamprecht
2024-02-09 13:08 ` [pve-devel] [PATCH manager 2/3] ui: user edit: hide key field except for legacy values Fiona Ebner
2024-02-09 13:08 ` [pve-devel] [PATCH manager 3/3] ui: user edit: prohibit editing keys option Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209130821.51461-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox