From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 2/4] QMP client: remove unnecessary question mark from comment
Date: Fri, 9 Feb 2024 13:14:25 +0100 [thread overview]
Message-ID: <20240209121427.39046-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20240209121427.39046-1-f.ebner@proxmox.com>
There might've been a question back when it got first added in commit
9d689077 ("use long timeouts for snapshot monitor command"). But
nowadays, the value is well-established. Changing it would affect
quite a few operations, so that should not be done without good
reason and is likely better done for the specific operation.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/QMPClient.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm
index 0a35db74..42e54f01 100644
--- a/PVE/QMPClient.pm
+++ b/PVE/QMPClient.pm
@@ -132,7 +132,7 @@ sub cmd {
$cmd->{execute} eq 'blockdev-snapshot-internal-sync' ||
$cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync'
) {
- $timeout = 10*60; # 10 mins ?
+ $timeout = 10*60; # 10 mins
} else {
# NOTE: if you came here as user and want to change this, try using IO-Threads first
# which move out quite some processing of the main thread, leaving more time for QMP
--
2.39.2
next prev parent reply other threads:[~2024-02-09 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 12:14 [pve-devel] [PATCH-SERIES qemu-server] small improvements in QMP client module Fiona Ebner
2024-02-09 12:14 ` [pve-devel] [PATCH qemu-server 1/4] QMP client: increase default timeout for drive-mirror to 10 minutes Fiona Ebner
2024-02-09 12:14 ` Fiona Ebner [this message]
2024-02-09 12:14 ` [pve-devel] [PATCH qemu-server 3/4] QMP client: add missing use statement Fiona Ebner
2024-02-09 12:14 ` [pve-devel] [RFC qemu-server 4/4] QMP client: code cleanup: sort commands with 10 minutes timeout alphabetically Fiona Ebner
2024-03-08 13:48 ` [pve-devel] applied-series: [PATCH-SERIES qemu-server] small improvements in QMP client module Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209121427.39046-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox