[pve-devel] [PATCH installer] proxinstall, common: remove "off" as zfs checksum option

[pve-devel] [PATCH installer] proxinstall, common: remove "off" as zfs checksum option

[Christoph Heiss]

See also the thread at [0] for the initial discussion/idea.

Disabling checksums is considered an "extraordinarily bad idea" [1] (for
pretty obvious reason) and nobody should really ever use it.

Thus remove the option completely; just so that users cannot simply
disable checksum "for performance reasons" without knowing about the
implications of this.

As pointed out by Thomas, it can still be set to "off" after the
installation using the `zfs` tool, if really wanted.

[0] https://lists.proxmox.com/pipermail/pve-devel/2023-December/061188.html
[1] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/Checksums.html#disabling-checksums

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 proxinstall                             | 2 +-
 proxmox-installer-common/src/options.rs | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/proxinstall b/proxinstall
index d6d5acb..81dd368 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1145,7 +1145,7 @@ my $create_raid_advanced_grid = sub {

     my $combo_checksum = Gtk3::ComboBoxText->new();
     $combo_checksum->set_tooltip_text("zfs checksum algorithm for rpool dataset");
-    my $csum_opts = ["on", "off", "fletcher4", "sha256"];
+    my $csum_opts = ["on", "fletcher4", "sha256"];
     foreach my $opt (@$csum_opts) {
 	$combo_checksum->append($opt, $opt);
     }
diff --git a/proxmox-installer-common/src/options.rs b/proxmox-installer-common/src/options.rs
index 98cd907..1aa8f65 100644
--- a/proxmox-installer-common/src/options.rs
+++ b/proxmox-installer-common/src/options.rs
@@ -145,7 +145,6 @@ pub const ZFS_COMPRESS_OPTIONS: &[ZfsCompressOption] = {
 pub enum ZfsChecksumOption {
     #[default]
     On,
-    Off,
     Fletcher4,
     Sha256,
 }
@@ -164,7 +163,7 @@ impl From<&ZfsChecksumOption> for String {

 pub const ZFS_CHECKSUM_OPTIONS: &[ZfsChecksumOption] = {
     use ZfsChecksumOption::*;
-    &[On, Off, Fletcher4, Sha256]
+    &[On, Fletcher4, Sha256]
 };

 #[derive(Clone, Debug)]
--
2.43.0