From: Alexander Zeidler <a.zeidler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 manager] pvesubscription: add missing return statement
Date: Mon, 29 Jan 2024 10:47:05 +0100 [thread overview]
Message-ID: <20240129094705.18951-1-a.zeidler@proxmox.com> (raw)
to avoid a failing null check and its error message. This confused
users since the activation was successful anyway.
Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
v2:
* use "return" instead of "return undef"
* add commit message
v1: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061280.html
PVE/CLI/pvesubscription.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/CLI/pvesubscription.pm b/PVE/CLI/pvesubscription.pm
index efd4ada4..51f5b71e 100755
--- a/PVE/CLI/pvesubscription.pm
+++ b/PVE/CLI/pvesubscription.pm
@@ -48,6 +48,8 @@ __PACKAGE__->register_method({
PVE::API2::Subscription::check_key($info->{key}, PVE::API2::Subscription::get_sockets());
PVE::API2::Subscription::write_etc_subscription($info);
+
+ return;
}});
our $cmddef = {
--
2.39.2
next reply other threads:[~2024-01-29 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 9:47 Alexander Zeidler [this message]
2024-02-02 18:17 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129094705.18951-1-a.zeidler@proxmox.com \
--to=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox