* [pve-devel] [PATCH manager] vzdump: also warn when hook script fails for backup-abort or log-end phase
@ 2024-01-22 9:55 Fiona Ebner
2024-04-23 14:48 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2024-01-22 9:55 UTC (permalink / raw)
To: pve-devel
to make it more visible, also in task logs.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/VZDump.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 4185ed62..98641f5a 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -1269,6 +1269,7 @@ sub exec_backup_task {
debugmsg ('info', "Failed at " . strftime("%F %H:%M:%S", localtime()));
eval { $self->run_hook_script ('backup-abort', $task, $logfd); };
+ debugmsg('warn', $@) if $@; # message already contains command with phase name
} else {
$task->{state} = 'ok';
@@ -1300,6 +1301,7 @@ sub exec_backup_task {
}
eval { $self->run_hook_script ('log-end', $task); };
+ debugmsg('warn', $@) if $@; # message already contains command with phase name
die $err if $err && $err =~ m/^interrupted by signal$/;
}
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] vzdump: also warn when hook script fails for backup-abort or log-end phase
2024-01-22 9:55 [pve-devel] [PATCH manager] vzdump: also warn when hook script fails for backup-abort or log-end phase Fiona Ebner
@ 2024-04-23 14:48 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-04-23 14:48 UTC (permalink / raw)
To: Proxmox VE development discussion, Fiona Ebner
Am 22/01/2024 um 10:55 schrieb Fiona Ebner:
> to make it more visible, also in task logs.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/VZDump.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-23 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-22 9:55 [pve-devel] [PATCH manager] vzdump: also warn when hook script fails for backup-abort or log-end phase Fiona Ebner
2024-04-23 14:48 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox