From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: display edit: add warning when SPICE memory configuration can lead to failing display initialization
Date: Fri, 12 Jan 2024 13:56:39 +0100 [thread overview]
Message-ID: <20240112125639.47941-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20240112125639.47941-1-f.ebner@proxmox.com>
which happens with either SeaBIOS+q35 or OVMF+efitype=2m as reported
in https://bugzilla.proxmox.com/show_bug.cgi?id=3726
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
www/manager6/qemu/DisplayEdit.js | 40 ++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js
index 9bb1763e..10ef3242 100644
--- a/www/manager6/qemu/DisplayEdit.js
+++ b/www/manager6/qemu/DisplayEdit.js
@@ -3,6 +3,8 @@ Ext.define('PVE.qemu.DisplayInputPanel', {
xtype: 'pveDisplayInputPanel',
onlineHelp: 'qm_display',
+ spiceMemoryHintRelevant: false,
+
onGetValues: function(values) {
let ret = PVE.Parser.printPropertyString(values, 'type');
if (ret === '') {
@@ -11,6 +13,16 @@ Ext.define('PVE.qemu.DisplayInputPanel', {
return { vga: ret };
},
+ updateSpiceMemoryHint: function() {
+ if (this.spiceMemoryHintRelevant) {
+ let type = this.down('field[name=type]').getValue();
+ let memory = this.down('field[name=memory]').getValue();
+ this.down('label[name=spice-memory-hint]').setHidden(
+ !type?.match(/^qxl\d?$/) || memory <= 128
+ );
+ }
+ },
+
items: [{
name: 'type',
xtype: 'proxmoxKVComboBox',
@@ -49,6 +61,8 @@ Ext.define('PVE.qemu.DisplayInputPanel', {
memoryfield.setEmptyText(Proxmox.Utils.defaultText);
}
memoryfield.setDisabled(disableMemoryField);
+
+ this.up('panel').updateSpiceMemoryHint();
},
},
},
@@ -60,6 +74,18 @@ Ext.define('PVE.qemu.DisplayInputPanel', {
maxValue: 512,
step: 4,
name: 'memory',
+ listeners: {
+ change: function(cb, val) {
+ this.up('panel').updateSpiceMemoryHint();
+ },
+ },
+ },
+ {
+ xtype: 'label',
+ text: gettext("SPICE memory > 128 MiB may not work with current EFI type or machine type"),
+ userCls: 'pmx-hint',
+ name: 'spice-memory-hint',
+ hidden: true,
}],
});
@@ -83,6 +109,20 @@ Ext.define('PVE.qemu.DisplayEdit', {
me.load({
success: function(response) {
me.vmconfig = response.result.data;
+
+ // see bug #3726
+ if (me.vmconfig.bios === 'ovmf') {
+ let efitype = '2m';
+ if (me.vmconfig.efidisk0) {
+ let drive = PVE.Parser.parsePropertyString(me.vmconfig.efidisk0, 'file');
+ efitype = drive.efitype ? drive.efitype : efitype;
+ }
+ me.down('pveDisplayInputPanel').spiceMemoryHintRelevant = efitype === '2m';
+ } else {
+ me.down('pveDisplayInputPanel').spiceMemoryHintRelevant =
+ me.vmconfig.machine?.match(/q35/);
+ }
+
let vga = me.vmconfig.vga || '__default__';
me.setValues(PVE.Parser.parsePropertyString(vga, 'type'));
},
--
2.39.2
prev parent reply other threads:[~2024-01-12 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 12:56 [pve-devel] [PATCH qemu-server] config2command: " Fiona Ebner
2024-01-12 12:56 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112125639.47941-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox