[pve-devel] [PATCH widget-toolkit] fix #5074: notify: sendmail: smtp: fix mailto/mailto-user parameter deletion

[pve-devel] [PATCH widget-toolkit] fix #5074: notify: sendmail: smtp: fix mailto/mailto-user parameter deletion

[Fiona Ebner]

by doing a cbind of isCreate to the top-level widget so that cbind in
the nested widgets for deleteEmpty works.

In the GUI, when a sendmail/smtp target is edited and either
'Additional Recipients' or 'Recipients' is completely removed (only
possible if the other field contains a value), parameter deletion did
not work properly. After applying the changes, the old value would
still be in place.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/panel/EmailRecipientPanel.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/panel/EmailRecipientPanel.js b/src/panel/EmailRecipientPanel.js
index b2bc03c..da64f45 100644
--- a/src/panel/EmailRecipientPanel.js
+++ b/src/panel/EmailRecipientPanel.js
@@ -19,6 +19,9 @@ Ext.define('Proxmox.panel.EmailRecipientPanel', {
 	{
 	    layout: 'anchor',
 	    border: false,
+	    cbind: {
+		isCreate: '{isCreate}',
+	    },
 	    items: [
 		{
 		    xtype: 'pmxUserSelector',
-- 
2.39.2

Re: [pve-devel] [PATCH widget-toolkit] fix #5074: notify: sendmail: smtp: fix mailto/mailto-user parameter deletion

[Lukas Wagner]

On 1/4/24 13:38, Fiona Ebner wrote:
> by doing a cbind of isCreate to the top-level widget so that cbind in
> the nested widgets for deleteEmpty works.
> 
> In the GUI, when a sendmail/smtp target is edited and either
> 'Additional Recipients' or 'Recipients' is completely removed (only
> possible if the other field contains a value), parameter deletion did
> not work properly. After applying the changes, the old value would
> still be in place.
> 

I can confirm that this patch works as expected and fixes the issue.

Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>


-- 
- Lukas

[pve-devel] applied: [PATCH widget-toolkit] fix #5074: notify: sendmail: smtp: fix mailto/mailto-user parameter deletion

[Fiona Ebner]

Am 04.01.24 um 13:38 schrieb Fiona Ebner:
> by doing a cbind of isCreate to the top-level widget so that cbind in
> the nested widgets for deleteEmpty works.
> 
> In the GUI, when a sendmail/smtp target is edited and either
> 'Additional Recipients' or 'Recipients' is completely removed (only
> possible if the other field contains a value), parameter deletion did
> not work properly. After applying the changes, the old value would
> still be in place.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>

applied with Lukas' T-b and R-b tags, thanks for those!