public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Maximiliano Sandoval <m.sandoval@proxmox.com>,
	Mira Limbeck <mira.limbeck@gmail.com>
Subject: [pve-devel] [PATCH manager] ui: ceph installer: Run ceph/init if joining a cluster
Date: Mon, 18 Dec 2023 15:25:07 +0100	[thread overview]
Message-ID: <20231218142507.505335-1-m.sandoval@proxmox.com> (raw)

Currently joining an already existing Ceph cluster won't create symlinks
from /etc/pve/ceph.conf to /etc/ceph/ceph.conf on the recently added
node. This can be remediated by running `pveceph init` but ideally
should be done by the web UI.

We remediate this by setting `configuration` to false if we reach the
branch where `operation.error.statusText` matches:

    binary not installed: /usr/bin/ceph-mon

This allow us to configure this node and run `init` in the API.

Suggested-by: Mira Limbeck <mira.limbeck@gmail.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
This was found on a ticker from the support portal.

 www/manager6/ceph/CephInstallWizard.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js
index f33ae868..d3c46506 100644
--- a/www/manager6/ceph/CephInstallWizard.js
+++ b/www/manager6/ceph/CephInstallWizard.js
@@ -369,6 +369,9 @@ Ext.define('PVE.ceph.CephInstallWizard', {
 				    me.down('textfield').setValue('success');
 				} else if (!operation.error.statusText.match("not installed", "i")) {
 				    Proxmox.Utils.setErrorMask(me, operation.error.statusText);
+				} else {
+				    // For when we join an already existing Ceph cluster.
+				    me.up('pveCephInstallWizard').getViewModel().set('configuration', false);
 				}
 			    },
 			},
-- 
2.39.2





             reply	other threads:[~2023-12-18 14:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 14:25 Maximiliano Sandoval [this message]
2023-12-19 17:09 ` Aaron Lauterer
2023-12-20  9:53   ` Mira Limbeck
2023-12-20 12:24     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231218142507.505335-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=mira.limbeck@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal