From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] vzdump: make helper functions for sending notifications private
Date: Thu, 14 Dec 2023 15:11:54 +0100 [thread overview]
Message-ID: <20231214141154.279100-2-l.wagner@proxmox.com> (raw)
In-Reply-To: <20231214141154.279100-1-l.wagner@proxmox.com>
The helpers were split out from the original 'sendmail' function when
migrating to the new notification system. They are not needed anywhere
else and can thus be private.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
PVE/VZDump.pm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 91f60418..009eb369 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -318,7 +318,7 @@ sub read_vzdump_defaults {
return $res;
}
-sub read_backup_task_logs {
+my sub read_backup_task_logs {
my ($task_list) = @_;
my $task_logs = "";
@@ -345,7 +345,7 @@ sub read_backup_task_logs {
return $task_logs;
}
-sub build_guest_table {
+my sub build_guest_table {
my ($task_list) = @_;
my $table = {
@@ -399,7 +399,7 @@ sub build_guest_table {
return $table;
}
-sub sanitize_task_list {
+my sub sanitize_task_list {
my ($task_list) = @_;
for my $task (@$task_list) {
chomp $task->{msg} if $task->{msg};
@@ -427,7 +427,7 @@ my sub aggregate_task_statistics {
return $error_count, $total_size;
}
-sub get_hostname {
+my sub get_hostname {
my $hostname = `hostname -f` || PVE::INotify::nodename();
chomp $hostname;
return $hostname;
--
2.39.2
next prev parent reply other threads:[~2023-12-14 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 14:11 [pve-devel] [PATCH manager 1/2] fix #5067: vzdump: include total backup size in notification Lukas Wagner
2023-12-14 14:11 ` Lukas Wagner [this message]
2024-01-08 10:44 ` Lukas Wagner
2024-01-29 9:38 ` [pve-devel] applied-series: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214141154.279100-2-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox