From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 0/2] notification: set 'Remove' button text to 'Reset to default' for built-ins
Date: Thu, 14 Dec 2023 10:48:42 +0100 [thread overview]
Message-ID: <20231214094844.84950-1-l.wagner@proxmox.com> (raw)
Deleting a built-in target/matcher does not remove it, but resets it
to its default settings. This was not really obvious from the UI.
This patch changes the 'Remove' button text based on the
selected target/matcher. If it is a built-in, the button text is
changed to 'Reset to default'. Also, if the built-in is not actually
modified, the button is disabled.
Lukas Wagner (2):
remove button: allow to set custom confirmation message
notify: change 'Remove' button to 'Reset to default' for built-ins
src/button/Button.js | 10 ++++-
src/panel/NotificationConfigView.js | 63 +++++++++++++++++++++++++++++
2 files changed, 72 insertions(+), 1 deletion(-)
--
2.39.2
next reply other threads:[~2023-12-14 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 9:48 Lukas Wagner [this message]
2023-12-14 9:48 ` [pve-devel] [PATCH widget-toolkit 1/2] remove button: allow to set custom confirmation message Lukas Wagner
2023-12-14 9:48 ` [pve-devel] [PATCH widget-toolkit 2/2] notify: change 'Remove' button to 'Reset to default' for built-ins Lukas Wagner
2024-01-08 10:43 ` [pve-devel] [PATCH widget-toolkit 0/2] notification: set 'Remove' button text " Lukas Wagner
2024-02-16 10:15 ` Lukas Wagner
2024-04-10 10:25 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214094844.84950-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox