From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 guest-common 3/3] abstract config: fix snapshot needed by replication check
Date: Wed, 13 Dec 2023 15:17:47 +0100 [thread overview]
Message-ID: <20231213141747.679613-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20231213141747.679613-1-f.ebner@proxmox.com>
Do not pass the cleanup flag to get_replicatable_volumes() which leads
to replicatable volumes that have the replicate setting turned off to
be part of the result.
Instead pass the noerr flag, because things like missing the
storage-level replicate feature should not lead to an error here.
Reported in the community forum:
https://forum.proxmox.com/threads/120910/post-605574
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
New in v2.
src/PVE/AbstractConfig.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm
index a286b13..5d5f9b4 100644
--- a/src/PVE/AbstractConfig.pm
+++ b/src/PVE/AbstractConfig.pm
@@ -862,7 +862,7 @@ my $snapshot_delete_assert_not_needed_by_replication = sub {
my $storecfg = PVE::Storage::config();
# Current config's volumes are relevant for replication.
- my $volumes = $class->get_replicatable_volumes($storecfg, $vmid, $conf, 1);
+ my $volumes = $class->get_replicatable_volumes($storecfg, $vmid, $conf, 0, 1);
my $replication_jobs = $repl_conf->list_guests_local_replication_jobs($vmid);
--
2.39.2
next prev parent reply other threads:[~2023-12-13 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 14:17 [pve-devel] [PATCH-SERIES v2 guest-common] replication improvements Fiona Ebner
2023-12-13 14:17 ` [pve-devel] [PATCH v2 guest-common 1/3] replication: prepare: include volumes without snapshots in the result Fiona Ebner
2023-12-13 14:17 ` [pve-devel] [PATCH v2 guest-common 2/3] replication: find common base: improve error when no common base snapshot exists Fiona Ebner
2023-12-13 14:17 ` Fiona Ebner [this message]
2024-04-11 11:58 ` [pve-devel] [PATCH-SERIES v2 guest-common] replication improvements Fiona Ebner
2024-04-11 16:18 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213141747.679613-4-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox