public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Folke Gleumes <f.gleumes@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC cluster/common/widget-toolkit/manager 0/4] split node memory graph into usage types
Date: Mon, 11 Dec 2023 15:47:17 +0100	[thread overview]
Message-ID: <20231211144721.212071-1-f.gleumes@proxmox.com> (raw)

The goal of this patchseries is to make it more intuitive to understand
the memory usage of an instance by splitting the memory usage graph
into 'Used', 'Buffer/Cache', 'ZFS Arc' and 'Free' instead of 'Total'
and 'RAM usage', displayed as different colored segments in a stacking
graph that adds up to the total memory. Previously, the zfs arc counted
towards the used memory, which could give a skewed perspective, since
there is no visual difference between almost all memory being used with
next to no arc or half of the memory used with a big arc.

Since there has already been a heated discussion on Bugzilla [0] on what
to display, I thought I would post this as an RFC before I finish up the
patchseries.

Another question would be if other places that display the memory usage
should also be split, i.e. the progress bar and gauge chart in the
cluster overview. Previously they included the zfs arc, with this series
the arc is not counted as used memory, since it technically can be freed
(with some caveats).

Unfortunately, there is a visual inconsistency with the way that missing
data is displayed in the new graph, since it seems impossible to display
missing data as a gap when using an area graph, which is possible and
the default in the line graph that is used throughout the rest of the
ui.

Note that applying this patch will currently reset your metrics, so
you'll have to wait a bit to see results.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=1454

cluster: Folke Gleumes (1):
  rrd: add free, buffer/cache and arc size to memory statistics

 src/pmxcfs/status.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

common: Folke Gleumes (1):
  add more detailed statistics to memory report

 src/PVE/ProcFSTools.pm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

widget-toolkit: Folke Gleumes (1):
  add option to display rrd graph as stacking

 src/panel/RRDChart.js | 59 +++++++++++++++++++++++++++++++++----------
 1 file changed, 46 insertions(+), 13 deletions(-)

manager: Folke Gleumes (1):
  split ram usage into usage types

 PVE/API2/Nodes.pm            |  6 +++---
 PVE/API2Tools.pm             |  2 +-
 PVE/Service/pvestatd.pm      | 15 +++++++++++----
 www/manager6/node/Summary.js |  6 ++++--
 4 files changed, 19 insertions(+), 10 deletions(-)

-- 
2.39.2





             reply	other threads:[~2023-12-11 14:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 14:47 Folke Gleumes [this message]
2023-12-11 14:47 ` [pve-devel] [RFC cluster 1/4] rrd: add free, buffer/cache and arc size to memory statistics Folke Gleumes
2023-12-12  7:49   ` DERUMIER, Alexandre
2023-12-11 14:47 ` [pve-devel] [RFC common 2/4] add more detailed statistics to memory report Folke Gleumes
2023-12-11 14:47 ` [pve-devel] [RFC widget-toolkit 3/4] add option to display rrd graph as stacking Folke Gleumes
2023-12-11 14:47 ` [pve-devel] [RFC manager 4/4] split ram usage into usage types Folke Gleumes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231211144721.212071-1-f.gleumes@proxmox.com \
    --to=f.gleumes@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal