public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-widget-toolkit 14/21] combogrid: add 'showClearTrigger' config
Date: Mon, 11 Dec 2023 13:49:48 +0100	[thread overview]
Message-ID: <20231211124955.211219-15-l.wagner@proxmox.com> (raw)
In-Reply-To: <20231211124955.211219-1-l.wagner@proxmox.com>

This allows one configure the clear trigger to be shown, even if
'allowBlank' is set false. This can be useful if one has a
non-editable combogrid where the value is set to something not
present in the store. Example: Match rule editing, one selects
a backup job to be match. If the backup job is removed and the match
rule edit window is opened again, then the old, deleted value cannot
be removed from the combogrid if there is no clear trigger.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 src/form/ComboGrid.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js
index 6338a3a..3aaa717 100644
--- a/src/form/ComboGrid.js
+++ b/src/form/ComboGrid.js
@@ -32,6 +32,7 @@ Ext.define('Proxmox.form.ComboGrid', {
 	notFoundIsValid: false,
 	deleteEmpty: false,
 	errorHeight: 100,
+	showClearTrigger: false,
     },
 
     // needed to trigger onKeyUp etc.
@@ -54,7 +55,10 @@ Ext.define('Proxmox.form.ComboGrid', {
     setValue: function(value) {
 	let me = this;
 	let empty = Ext.isArray(value) ? !value.length : !value;
-	me.triggers.clear.setVisible(!empty && me.allowBlank);
+	me.triggers.clear.setVisible(
+	    (!empty && me.allowBlank) ||
+	    (!empty && me.showClearTrigger),
+	);
 	return me.callParent([value]);
     },
 
-- 
2.39.2





  parent reply	other threads:[~2023-12-11 12:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 12:49 [pve-devel] [PATCH many 00/21] notifications: notification metadata matching improvements Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH proxmox 01/21] notify: include 'hostname' metadata field for forwarded mails Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH proxmox 02/21] notify: matcher: support lists of values for 'exact' match-field mode Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 03/21] api: notifications: add 'smtp' to target index Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 04/21] api: jobs: vzdump: pass job 'id' parameter Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 05/21] ui: dc: backup: send 'id' property when starting a backup job manually Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 06/21] ui: dc: backup: show 'Job ID' column Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 07/21] ui: dc: backup: allow to set custom job id in advanced settings Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 08/21] api: replication: add 'replication-job' to notification metadata Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 09/21] ui: replication: show 'Job ID' column Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 10/21] vzdump: apt: notification: do not include domain in 'hostname' field Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 11/21] api: replication: include 'hostname' field for notifications Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 12/21] api: notification: add API for getting known metadata fields/values Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-manager 13/21] ui: utils: add overrides for translatable notification fields/values Lukas Wagner
2023-12-11 12:49 ` Lukas Wagner [this message]
2023-12-11 12:49 ` [pve-devel] [PATCH proxmox-widget-toolkit 15/21] notification: matcher: match-field: show known fields/values Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH proxmox-widget-toolkit 16/21] notification: matcher: move match-field formulas to local viewModel Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH proxmox-widget-toolkit 17/21] notification: matcher: move match-calendar fields to panel Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH proxmox-widget-toolkit 18/21] notification: matcher: move match-severity " Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-docs 19/21] notification: clarify that 'hostname' does not include the domain Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-docs 20/21] notifications: describe new notification metadata fields Lukas Wagner
2023-12-11 12:49 ` [pve-devel] [PATCH pve-docs 21/21] notifications: match-field 'exact'-mode can now match multiple values Lukas Wagner
2023-12-11 13:50 ` [pve-devel] [PATCH many 00/21] notifications: notification metadata matching improvements Maximiliano Sandoval
2023-12-13 16:36 ` Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231211124955.211219-15-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal