public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC manager 1/1] ui: lvm: expose saferemove setting
Date: Thu,  7 Dec 2023 17:10:37 +0100	[thread overview]
Message-ID: <20231207161038.90626-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20231207161038.90626-1-f.ebner@proxmox.com>

It can be security-relevant in some environments. The LVM storage
documentation can be reached via the "Help" button and contains a few
more details.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 www/manager6/storage/LVMEdit.js | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
index fde302fc..37d3c6ef 100644
--- a/www/manager6/storage/LVMEdit.js
+++ b/www/manager6/storage/LVMEdit.js
@@ -228,5 +228,15 @@ Ext.define('PVE.storage.LVMInputPanel', {
 	    uncheckedValue: 0,
 	    fieldLabel: gettext('Shared'),
 	},
+	{
+	    xtype: 'proxmoxcheckbox',
+	    name: 'saferemove',
+	    uncheckedValue: 0,
+	    fieldLabel: gettext('Safe Remove'),
+	    autoEl: {
+		tag: 'div',
+		'data-qtip': gettext("Zero-out data when removing LVs"),
+	    },
+	},
     ],
 });
-- 
2.39.2





  reply	other threads:[~2023-12-07 16:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 16:10 [pve-devel] [RFC manager/docs] lvm: better expose/explain saferemove option Fiona Ebner
2023-12-07 16:10 ` Fiona Ebner [this message]
2024-01-09  9:49   ` [pve-devel] [RFC manager 1/1] ui: lvm: expose saferemove setting Fabian Grünbichler
2023-12-07 16:10 ` [pve-devel] [PATCH docs 1/1] storage: lvm: expand on description of saferemove option Fiona Ebner
2024-01-09  9:38   ` [pve-devel] applied: " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231207161038.90626-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal