[pve-devel] [PATCH manager] fix #5106: ui: ceph status: add error title to expandable body

[pve-devel] [PATCH manager] fix #5106: ui: ceph status: add error title to expandable body

[Dominik Csapak]

this has the advantage that the title is now completely visible when the
column is too narrow when expanded, although it is duplicated (since
it's already contained in the non expanded row) even if the original
value may be cutoff.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
not sure about this, because of the duplication, but i can't currently
think of a better way aside from telling the users to resize the column
and scroll to read the error message, or to reintroduce the popup dialog
that contains also both the summary and the detail...


 www/manager6/ceph/Status.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js
index ab882327..a1f6c67d 100644
--- a/www/manager6/ceph/Status.js
+++ b/www/manager6/ceph/Status.js
@@ -178,7 +178,7 @@ Ext.define('PVE.node.CephStatus', {
 			    ptype: 'rowexpander',
 			    expandOnDblClick: false,
 			    scrollIntoViewOnExpand: false,
-			    rowBodyTpl: '<pre class="pve-ceph-warning-detail {detailsCls}">{detail}</pre>',
+			    rowBodyTpl: '<pre class="pve-ceph-warning-detail {detailsCls}">{summary}\n\n{detail}</pre>',
 			},
 		    ],
 		},
-- 
2.30.2

Re: [pve-devel] [PATCH manager] fix #5106: ui: ceph status: add error title to expandable body

[Thomas Lamprecht]

Am 07/12/2023 um 12:01 schrieb Dominik Csapak:
> this has the advantage that the title is now completely visible when the
> column is too narrow when expanded, although it is duplicated (since
> it's already contained in the non expanded row) even if the original
> value may be cutoff.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> not sure about this, because of the duplication, but i can't currently
> think of a better way aside from telling the users to resize the column
> and scroll to read the error message, or to reintroduce the popup dialog
> that contains also both the summary and the detail...


What if we make this cell wrap words (e.g., with white-space: pre-wrap) on expand?