public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix #5106: ui: ceph status: add error title to expandable body
Date: Thu,  7 Dec 2023 12:01:32 +0100	[thread overview]
Message-ID: <20231207110132.3018159-1-d.csapak@proxmox.com> (raw)

this has the advantage that the title is now completely visible when the
column is too narrow when expanded, although it is duplicated (since
it's already contained in the non expanded row) even if the original
value may be cutoff.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
not sure about this, because of the duplication, but i can't currently
think of a better way aside from telling the users to resize the column
and scroll to read the error message, or to reintroduce the popup dialog
that contains also both the summary and the detail...


 www/manager6/ceph/Status.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js
index ab882327..a1f6c67d 100644
--- a/www/manager6/ceph/Status.js
+++ b/www/manager6/ceph/Status.js
@@ -178,7 +178,7 @@ Ext.define('PVE.node.CephStatus', {
 			    ptype: 'rowexpander',
 			    expandOnDblClick: false,
 			    scrollIntoViewOnExpand: false,
-			    rowBodyTpl: '<pre class="pve-ceph-warning-detail {detailsCls}">{detail}</pre>',
+			    rowBodyTpl: '<pre class="pve-ceph-warning-detail {detailsCls}">{summary}\n\n{detail}</pre>',
 			},
 		    ],
 		},
-- 
2.30.2





             reply	other threads:[~2023-12-07 11:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 11:01 Dominik Csapak [this message]
2023-12-07 11:56 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231207110132.3018159-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal