From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 0/6] switch low-level installer protocol to json
Date: Wed, 6 Dec 2023 12:34:49 +0100 [thread overview]
Message-ID: <20231206113456.411898-1-c.heiss@proxmox.com> (raw)
This switches the stdio-protocol for the low-level installer from
simple, line-based messages to JSON.
This solves a number of problems, most prominently that messages can now
contain multiline text (or for that matter, any kind of data), as JSON
handles that transparently.
The actual "meaty" changes are in #3, the others are either some simple
cleanups or test infra.
I have also included a testsuite for both the Perl side of things, as
well as the TUI, to ensure that it works and cannot be accidently broken
easily in the future.
Tested this by installing of PVE and PBS.
Christoph Heiss (6):
low-level: align wording of finish message
ui: stdio: log error if display_html() is called on stdio backend
tui, ui: switch over to JSON-based protocol
test: add tests for UI^2 stdio protocol
buildsys: setup proper test environment for testsuite
tui: install progress: add tests for UI^2 stdio protocol
Makefile | 9 +-
Proxmox/UI/StdIO.pm | 43 ++--
proxmox-low-level-installer | 2 +-
.../src/views/install_progress.rs | 195 +++++++++++++-----
test/Makefile | 6 +-
test/ui2-stdio.pl | 96 +++++++++
6 files changed, 280 insertions(+), 71 deletions(-)
create mode 100755 test/ui2-stdio.pl
--
2.42.0
next reply other threads:[~2023-12-06 11:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 11:34 Christoph Heiss [this message]
2023-12-06 11:34 ` [pve-devel] [PATCH installer 1/6] low-level: align wording of finish message Christoph Heiss
2023-12-06 11:34 ` [pve-devel] [PATCH installer 2/6] ui: stdio: log error if display_html() is called on stdio backend Christoph Heiss
2023-12-06 11:34 ` [pve-devel] [PATCH installer 3/6] tui, ui: switch over to JSON-based protocol Christoph Heiss
2024-02-24 16:55 ` Thomas Lamprecht
2023-12-06 11:34 ` [pve-devel] [PATCH installer 4/6] test: add tests for UI^2 stdio protocol Christoph Heiss
2023-12-06 11:34 ` [pve-devel] [PATCH installer 5/6] buildsys: setup proper test environment for testsuite Christoph Heiss
2023-12-06 11:34 ` [pve-devel] [PATCH installer 6/6] tui: install progress: add tests for UI^2 stdio protocol Christoph Heiss
2024-01-24 9:54 ` [pve-devel] [PATCH installer 0/6] switch low-level installer protocol to json Christoph Heiss
2024-02-26 14:07 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206113456.411898-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox