From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC pve-manager 1/2] multi disk edit: add copy button
Date: Tue, 5 Dec 2023 16:44:58 +0100 [thread overview]
Message-ID: <20231205154458.268660-3-m.carrara@proxmox.com> (raw)
In-Reply-To: <20231205154458.268660-1-m.carrara@proxmox.com>
Add a copy button that copies the configuration of one disk to a new
one.
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
---
www/manager6/panel/MultiDiskEdit.js | 78 +++++++++++++++++++++++++----
1 file changed, 68 insertions(+), 10 deletions(-)
diff --git a/www/manager6/panel/MultiDiskEdit.js b/www/manager6/panel/MultiDiskEdit.js
index ea1f974d..dffbb4c5 100644
--- a/www/manager6/panel/MultiDiskEdit.js
+++ b/www/manager6/panel/MultiDiskEdit.js
@@ -13,14 +13,37 @@ Ext.define('PVE.panel.MultiDiskPanel', {
controller: {
xclass: 'Ext.app.ViewController',
+ disableableButtons: ['addButton', 'copyButton'],
+
vmconfig: {},
onAdd: function() {
let me = this;
- me.lookup('addButton').setDisabled(true);
+ me.disableButtons();
me.addDisk();
- let count = me.lookup('grid').getStore().getCount() + 1; // +1 is from ide2
- me.lookup('addButton').setDisabled(count >= me.maxCount);
+ me.enableButtons();
+ },
+
+ onCopy: function(button, event) {
+ let me = this;
+ me.disableButtons();
+ me.addDisk(true);
+ me.enableButtons();
+ },
+
+ disableButtons: function() {
+ let me = this;
+ for (let buttonName of me.disableableButtons) {
+ me.lookup(buttonName).setDisabled(true);
+ }
+ },
+
+ enableButtons: function() {
+ let me = this;
+ let count = me.lookup('grid').getStore().getCount() + 1;
+ for (let buttonName of me.disableableButtons) {
+ me.lookup(buttonName).setDisabled(count >= me.maxCount);
+ }
},
getNextFreeDisk: function(vmconfig) {
@@ -34,7 +57,7 @@ Ext.define('PVE.panel.MultiDiskPanel', {
// define in subclass
diskSorter: undefined,
- addDisk: function() {
+ addDisk: function(copy = false) {
let me = this;
let grid = me.lookup('grid');
let store = grid.getStore();
@@ -54,6 +77,21 @@ Ext.define('PVE.panel.MultiDiskPanel', {
})[0];
let panel = me.addPanel(itemId, vmconfig, nextFreeDisk);
+
+ if (copy) {
+ let selection = grid.getSelection()[0];
+ let selectedItemId = selection.get('itemId');
+ let panelFrom = me.getView().getComponent(selectedItemId);
+
+ if (!panelFrom) {
+ throw "unexpected missing panel";
+ }
+
+ let values = panelFrom.getValues(false, true);
+ values.deviceid = nextFreeDisk.id;
+ panel.setValues(values);
+ }
+
panel.updateVMConfig(vmconfig);
// we need to setup a validitychange handler, so that we can show
@@ -170,7 +208,7 @@ Ext.define('PVE.panel.MultiDiskPanel', {
store.remove(record);
me.getView().remove(record.get('itemId'));
- me.lookup('addButton').setDisabled(false);
+ me.enableButtons();
me.updateVMConfig();
me.checkValidity();
},
@@ -251,11 +289,31 @@ Ext.define('PVE.panel.MultiDiskPanel', {
],
},
{
- xtype: 'button',
- reference: 'addButton',
- text: gettext('Add'),
- iconCls: 'fa fa-plus-circle',
- handler: 'onAdd',
+ layout: 'hbox',
+ border: false,
+ defaults: {
+ border: false,
+ layout: 'anchor',
+ flex: 1,
+ },
+ items: [
+ {
+ xtype: 'button',
+ reference: 'addButton',
+ text: gettext('Add'),
+ iconCls: 'fa fa-plus-circle',
+ handler: 'onAdd',
+ margin: '0 2.5 0 0',
+ },
+ {
+ xtype: 'button',
+ reference: 'copyButton',
+ text: gettext('Copy'),
+ iconCls: 'fa fa-files-o',
+ handler: 'onCopy',
+ margin: '0 0 0 2.5',
+ },
+ ],
},
{
// dummy field to control wizard validation
--
2.39.2
next prev parent reply other threads:[~2023-12-05 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 15:44 [pve-devel] [RFC proxmox-widget-toolkit, pve-manager 0/2] Copy Button For Wizard Disk Configuration Max Carrara
2023-12-05 15:44 ` [pve-devel] [RFC proxmox-widget-toolkit 1/2] input panel: add `raw` parameter to function `getValues` Max Carrara
2023-12-06 9:13 ` Dominik Csapak
2023-12-06 9:59 ` Max Carrara
2023-12-05 15:44 ` Max Carrara [this message]
2023-12-06 9:25 ` [pve-devel] [RFC pve-manager 1/2] multi disk edit: add copy button Dominik Csapak
2023-12-06 10:49 ` Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205154458.268660-3-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox