From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC proxmox-widget-toolkit 1/2] input panel: add `raw` parameter to function `getValues`
Date: Tue, 5 Dec 2023 16:44:57 +0100 [thread overview]
Message-ID: <20231205154458.268660-2-m.carrara@proxmox.com> (raw)
In-Reply-To: <20231205154458.268660-1-m.carrara@proxmox.com>
This parameter may be used to circumvent calls to `onGetValues`.
Also adds a docstring for the function.
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
---
src/panel/InputPanel.js | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/src/panel/InputPanel.js b/src/panel/InputPanel.js
index 34150ef..723be42 100644
--- a/src/panel/InputPanel.js
+++ b/src/panel/InputPanel.js
@@ -31,7 +31,16 @@ Ext.define('Proxmox.panel.InputPanel', {
return values;
},
- getValues: function(dirtyOnly) {
+ /**
+ * Returns the submit data from the panel's form fields.
+ *
+ * @param {boolean} dirtyOnly `true` to return only dirty fields
+ * (fields that have been changed from their original value).
+ * @param {boolean} raw `true` to prevent calling
+ * {@link Proxmox.panel.InputPanel#onGetValues onGetValues} and
+ * instead return the original submit data.
+ */
+ getValues: function(dirtyOnly, raw) {
let me = this;
if (Ext.isFunction(me.onGetValues)) {
@@ -46,6 +55,10 @@ Ext.define('Proxmox.panel.InputPanel', {
}
});
+ if (raw) {
+ return values;
+ }
+
return me.onGetValues(values);
},
--
2.39.2
next prev parent reply other threads:[~2023-12-05 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 15:44 [pve-devel] [RFC proxmox-widget-toolkit, pve-manager 0/2] Copy Button For Wizard Disk Configuration Max Carrara
2023-12-05 15:44 ` Max Carrara [this message]
2023-12-06 9:13 ` [pve-devel] [RFC proxmox-widget-toolkit 1/2] input panel: add `raw` parameter to function `getValues` Dominik Csapak
2023-12-06 9:59 ` Max Carrara
2023-12-05 15:44 ` [pve-devel] [RFC pve-manager 1/2] multi disk edit: add copy button Max Carrara
2023-12-06 9:25 ` Dominik Csapak
2023-12-06 10:49 ` Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205154458.268660-2-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox