public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC proxmox-widget-toolkit, pve-manager 0/2] Copy Button For Wizard Disk Configuration
Date: Tue,  5 Dec 2023 16:44:56 +0100	[thread overview]
Message-ID: <20231205154458.268660-1-m.carrara@proxmox.com> (raw)

When creating a VM for testing purposes, e.g. a VM that's supposed
to have 8 disks to test something in regards to ZFS, it's necessary
to manually edit the configuration and repeatedly click on all desired
options by hand - for every single disk. I always wished there was a
copy button, so I decided to just implement it myself.

These two patches are sent as RFC because I'm not 100% sure about the
some of the naming, approaches and UI design decisions I have made,
so it would be nice to get some feedback on that.

In particular:
- Maybe it's better to name the button "duplicate" instead of "copy"?
  * But that means it doesn't fit in the same row as the "add" button
- Put the copy button next to the little icon for the delete button
  instead, displaying it for each list item?


Max Carrara (1):
  input panel: add `raw` parameter to function `getValues`

 src/panel/InputPanel.js | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

Max Carrara (1):
  multi disk edit: add copy button

 www/manager6/panel/MultiDiskEdit.js | 78 +++++++++++++++++++++++++----
 1 file changed, 68 insertions(+), 10 deletions(-)


-- 
2.39.2





             reply	other threads:[~2023-12-05 15:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 15:44 Max Carrara [this message]
2023-12-05 15:44 ` [pve-devel] [RFC proxmox-widget-toolkit 1/2] input panel: add `raw` parameter to function `getValues` Max Carrara
2023-12-06  9:13   ` Dominik Csapak
2023-12-06  9:59     ` Max Carrara
2023-12-05 15:44 ` [pve-devel] [RFC pve-manager 1/2] multi disk edit: add copy button Max Carrara
2023-12-06  9:25   ` Dominik Csapak
2023-12-06 10:49     ` Max Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231205154458.268660-1-m.carrara@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal