public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox 1/5] time: posix: use strftime from the `libc` crate.
Date: Tue,  5 Dec 2023 13:11:38 +0100	[thread overview]
Message-ID: <20231205121142.169542-2-l.wagner@proxmox.com> (raw)
In-Reply-To: <20231205121142.169542-1-l.wagner@proxmox.com>

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 proxmox-time/src/posix.rs | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/proxmox-time/src/posix.rs b/proxmox-time/src/posix.rs
index 6157f8b..c463ab3 100644
--- a/proxmox-time/src/posix.rs
+++ b/proxmox-time/src/posix.rs
@@ -108,25 +108,13 @@ pub fn epoch_f64() -> f64 {
     }
 }
 
-//  rust libc bindings do not include strftime
-#[link(name = "c")]
-extern "C" {
-    #[link_name = "strftime"]
-    fn libc_strftime(
-        s: *mut libc::c_char,
-        max: libc::size_t,
-        format: *const libc::c_char,
-        time: *const libc::tm,
-    ) -> libc::size_t;
-}
-
 /// Safe bindings to libc strftime
 pub fn strftime(format: &str, t: &libc::tm) -> Result<String, Error> {
     let format = CString::new(format).map_err(|err| format_err!("{}", err))?;
     let mut buf = vec![0u8; 8192];
 
     let res = unsafe {
-        libc_strftime(
+        libc::strftime(
             buf.as_mut_ptr() as *mut libc::c_char,
             buf.len() as libc::size_t,
             format.as_ptr(),
-- 
2.39.2





  reply	other threads:[~2023-12-05 12:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 12:11 [pve-devel] [PATCH proxmox 0/5] sys: email: always format 'Date' header with C locale Lukas Wagner
2023-12-05 12:11 ` Lukas Wagner [this message]
2023-12-05 12:11 ` [pve-devel] [PATCH proxmox 2/5] time: posix: inline vars in string formatting Lukas Wagner
2023-12-05 12:11 ` [pve-devel] [PATCH proxmox 3/5] time: posix: add bindings for strftime_l Lukas Wagner
2023-12-05 12:11 ` [pve-devel] [PATCH proxmox 4/5] time: posix: add epoch_to_rfc2822 Lukas Wagner
2023-12-11 13:06   ` Lukas Wagner
2023-12-05 12:11 ` [pve-devel] [PATCH proxmox 5/5] sys: email: use `epoch_to_rfc2822` from proxmox_time Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231205121142.169542-2-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal