* [pve-devel] [PATCH manager] ui: iso selector: fix disabling
@ 2023-12-04 9:29 Fiona Ebner
2023-12-04 15:48 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2023-12-04 9:29 UTC (permalink / raw)
To: pve-devel
Otherwise, it's impossible to add no or a physical CD to an existing
VM.
Reported in the communiy forum:
https://forum.proxmox.com/threads/136960/post-611704
Fixes: fc7b556d ("ui: refactor iso-selector out of the cd input panel")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
www/manager6/form/IsoSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/form/IsoSelector.js b/www/manager6/form/IsoSelector.js
index 0bc6346c..0f1bf744 100644
--- a/www/manager6/form/IsoSelector.js
+++ b/www/manager6/form/IsoSelector.js
@@ -61,7 +61,7 @@ Ext.define('PVE.form.IsoSelector', {
let me = this;
me.lookup('storage').setDisabled(disabled);
me.lookup('file').setDisabled(disabled);
- me.callParent();
+ return me.callParent([disabled]);
},
referenceHolder: true,
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: iso selector: fix disabling
2023-12-04 9:29 [pve-devel] [PATCH manager] ui: iso selector: fix disabling Fiona Ebner
@ 2023-12-04 15:48 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-12-04 15:48 UTC (permalink / raw)
To: Proxmox VE development discussion, Fiona Ebner
Am 04/12/2023 um 10:29 schrieb Fiona Ebner:
> Otherwise, it's impossible to add no or a physical CD to an existing
> VM.
>
> Reported in the communiy forum:
> https://forum.proxmox.com/threads/136960/post-611704
>
> Fixes: fc7b556d ("ui: refactor iso-selector out of the cd input panel")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> www/manager6/form/IsoSelector.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
But reworded the commit message and subject, as this was a bit lacking
IMO.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-04 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-04 9:29 [pve-devel] [PATCH manager] ui: iso selector: fix disabling Fiona Ebner
2023-12-04 15:48 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox