From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: iso selector: correctly disable itself
Date: Thu, 23 Nov 2023 13:36:52 +0100 [thread overview]
Message-ID: <20231123123652.2173444-1-d.csapak@proxmox.com> (raw)
we overwrote the 'setDisabled' method to disable the child elements, but
forgot to give the arguments to callParent, which means it never
disabled the IsoSelector.
This fixes an issue where when disabling the virtio iso selector in the
wizard again, the wizard would get invalid data from it.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/form/IsoSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/form/IsoSelector.js b/www/manager6/form/IsoSelector.js
index 0bc6346c..408c1fa3 100644
--- a/www/manager6/form/IsoSelector.js
+++ b/www/manager6/form/IsoSelector.js
@@ -61,7 +61,7 @@ Ext.define('PVE.form.IsoSelector', {
let me = this;
me.lookup('storage').setDisabled(disabled);
me.lookup('file').setDisabled(disabled);
- me.callParent();
+ me.callParent(arguments);
},
referenceHolder: true,
--
2.30.2
reply other threads:[~2023-11-23 12:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123123652.2173444-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox