[pve-devel] [PATCH manager v2 1/2] ui: resource tree: optimize change detection

[pve-devel] [PATCH manager v2 1/2] ui: resource tree: optimize change detection

[Dominik Csapak]

the 'text' property comes from the ResourceStore, but we often replace
it here before rendering, so this will trigger every time for tree
elements where we make use of 'setText'.

Instead, check for the 'name' property. To ensure the tags get updated
with the correct colors, listen to the 'loadedUiOptions' event and
mark every node changed for the next update cycle.

This way the calls to setText, etc. should be drastically reduced.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
this is a partial replacement for:
https://lists.proxmox.com/pipermail/pve-devel/2023-November/060774.html

changes from v1:
* split out the optimization
* to show the current tag override colors, redraw the elements when
  there was a 'loadedUiOptions' event

 www/manager6/tree/ResourceTree.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index d3c15aec..e07e4ba0 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -264,7 +264,7 @@ Ext.define('PVE.tree.ResourceTree', {
 	let stateid = 'rid';
 
 	const changedFields = [
-	    'text', 'running', 'template', 'status', 'qmpstatus', 'hastate', 'lock', 'tags',
+	    'name', 'running', 'template', 'status', 'qmpstatus', 'hastate', 'lock', 'tags',
 	];
 
 	let updateTree = function() {
@@ -294,6 +294,9 @@ Ext.define('PVE.tree.ResourceTree', {
 		let item = rstore.data.get(olditem.data.id);
 
 		let changed = sorting_changed, moved = sorting_changed;
+		if (me.needsUpdate) {
+		    changed = true;
+		}
 		if (item) {
 		    // test if any grouping attributes changed, catches migrated tree-nodes in server view too
 		    for (const attr of moveCheckAttrs) {
@@ -376,6 +379,7 @@ Ext.define('PVE.tree.ResourceTree', {
 	    }
 
 	    pdata.updateCount++;
+	    me.needsUpdate = false;
 	};
 
 	sp.on('statechange', (_sp, key, value) => {
@@ -498,6 +502,10 @@ Ext.define('PVE.tree.ResourceTree', {
 
 	rstore.on("load", updateTree);
 	rstore.startUpdate();
+
+	me.mon(Ext.GlobalEvents, 'loadedUiOptions', () => {
+	    me.needsUpdate = true;
+	});
     },
 
 });
-- 
2.30.2

[pve-devel] [PATCH manager v2 2/2] ui: resource tree: always show node tooltip

[Dominik Csapak]

not only when we're in the folder view

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* split out the node logic
* removed the unnecessary 'setText' calls (they did not do anything in
  those cases anyway)

requires the previous patch, otherwise the text for nodes in the server
view will be overwritten and the tooltip will now show there

 www/manager6/tree/ResourceTree.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index e07e4ba0..b265eaed 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -134,7 +134,7 @@ Ext.define('PVE.tree.ResourceTree', {
     },
 
     getToolTip: function(info) {
-	if (info.type === 'pool' || info.groupbyid !== undefined) {
+	if (info.type === 'pool' || (info.groupbyid !== undefined && info.type !== 'node')) {
 	    return undefined;
 	}
 
-- 
2.30.2