From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 2/2] ui: resource tree: always show node tooltip
Date: Thu, 23 Nov 2023 10:14:35 +0100 [thread overview]
Message-ID: <20231123091435.1548813-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20231123091435.1548813-1-d.csapak@proxmox.com>
not only when we're in the folder view
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* split out the node logic
* removed the unnecessary 'setText' calls (they did not do anything in
those cases anyway)
requires the previous patch, otherwise the text for nodes in the server
view will be overwritten and the tooltip will now show there
www/manager6/tree/ResourceTree.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index e07e4ba0..b265eaed 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -134,7 +134,7 @@ Ext.define('PVE.tree.ResourceTree', {
},
getToolTip: function(info) {
- if (info.type === 'pool' || info.groupbyid !== undefined) {
+ if (info.type === 'pool' || (info.groupbyid !== undefined && info.type !== 'node')) {
return undefined;
}
--
2.30.2
prev parent reply other threads:[~2023-11-23 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 9:14 [pve-devel] [PATCH manager v2 1/2] ui: resource tree: optimize change detection Dominik Csapak
2023-11-23 9:14 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123091435.1548813-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox