* [pve-devel] [PATCH widget-toolkit 1/2] notification ui: change icon for for match-field tree nodes
@ 2023-11-23 8:57 Lukas Wagner
2023-11-23 8:57 ` [pve-devel] [PATCH widget-toolkit 2/2] notification ui: display yellow warning triangle instead of red icon Lukas Wagner
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2023-11-23 8:57 UTC (permalink / raw)
To: pve-devel
The old icon was slightly ambiguous since we also use it for LXC
containers.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/window/NotificationMatcherEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js
index 03b453d..5e81e40 100644
--- a/src/window/NotificationMatcherEdit.js
+++ b/src/window/NotificationMatcherEdit.js
@@ -600,7 +600,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', {
let field = data.field;
let value = data.value;
text = Ext.String.format(gettext("Match field: {0}={1}"), field, value);
- iconCls = 'fa fa-cube';
+ iconCls = 'fa fa-square-o';
if (!field || !value) {
iconCls += ' critical';
}
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] [PATCH widget-toolkit 2/2] notification ui: display yellow warning triangle instead of red icon
2023-11-23 8:57 [pve-devel] [PATCH widget-toolkit 1/2] notification ui: change icon for for match-field tree nodes Lukas Wagner
@ 2023-11-23 8:57 ` Lukas Wagner
0 siblings, 0 replies; 2+ messages in thread
From: Lukas Wagner @ 2023-11-23 8:57 UTC (permalink / raw)
To: pve-devel
Instead of coloring the entire icon red, show a yellow warning
triangle containing an exclamation mark in case of validation errors.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/window/NotificationMatcherEdit.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js
index 5e81e40..f88576a 100644
--- a/src/window/NotificationMatcherEdit.js
+++ b/src/window/NotificationMatcherEdit.js
@@ -593,7 +593,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', {
text = Ext.String.format(gettext("Match severity: {0}"), v);
iconCls = 'fa fa-exclamation';
if (!v) {
- iconCls += ' critical';
+ iconCls += ' internal-error';
}
} break;
case 'match-field': {
@@ -602,7 +602,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', {
text = Ext.String.format(gettext("Match field: {0}={1}"), field, value);
iconCls = 'fa fa-square-o';
if (!field || !value) {
- iconCls += ' critical';
+ iconCls += ' internal-error';
}
} break;
case 'match-calendar': {
@@ -610,7 +610,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', {
text = Ext.String.format(gettext("Match calendar: {0}"), v);
iconCls = 'fa fa-calendar-o';
if (!v || !v.length) {
- iconCls += ' critical';
+ iconCls += ' internal-error';
}
} break;
case 'mode':
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-23 8:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-23 8:57 [pve-devel] [PATCH widget-toolkit 1/2] notification ui: change icon for for match-field tree nodes Lukas Wagner
2023-11-23 8:57 ` [pve-devel] [PATCH widget-toolkit 2/2] notification ui: display yellow warning triangle instead of red icon Lukas Wagner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox