From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 2/2] notification ui: display yellow warning triangle instead of red icon
Date: Thu, 23 Nov 2023 09:57:56 +0100 [thread overview]
Message-ID: <20231123085756.41987-2-l.wagner@proxmox.com> (raw)
In-Reply-To: <20231123085756.41987-1-l.wagner@proxmox.com>
Instead of coloring the entire icon red, show a yellow warning
triangle containing an exclamation mark in case of validation errors.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/window/NotificationMatcherEdit.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js
index 5e81e40..f88576a 100644
--- a/src/window/NotificationMatcherEdit.js
+++ b/src/window/NotificationMatcherEdit.js
@@ -593,7 +593,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', {
text = Ext.String.format(gettext("Match severity: {0}"), v);
iconCls = 'fa fa-exclamation';
if (!v) {
- iconCls += ' critical';
+ iconCls += ' internal-error';
}
} break;
case 'match-field': {
@@ -602,7 +602,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', {
text = Ext.String.format(gettext("Match field: {0}={1}"), field, value);
iconCls = 'fa fa-square-o';
if (!field || !value) {
- iconCls += ' critical';
+ iconCls += ' internal-error';
}
} break;
case 'match-calendar': {
@@ -610,7 +610,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', {
text = Ext.String.format(gettext("Match calendar: {0}"), v);
iconCls = 'fa fa-calendar-o';
if (!v || !v.length) {
- iconCls += ' critical';
+ iconCls += ' internal-error';
}
} break;
case 'mode':
--
2.39.2
prev parent reply other threads:[~2023-11-23 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 8:57 [pve-devel] [PATCH widget-toolkit 1/2] notification ui: change icon for for match-field tree nodes Lukas Wagner
2023-11-23 8:57 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123085756.41987-2-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox