public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-network] subnets: only delete macs.db entries if mac is available
@ 2023-11-22 12:27 Stefan Hanreich
  2023-11-22 13:07 ` [pve-devel] applied: " Wolfgang Bumiller
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hanreich @ 2023-11-22 12:27 UTC (permalink / raw)
  To: pve-devel; +Cc: Stefan Hanreich, Wolfgang Bumiller

When removing a gateway do not attempt to delete its entry from
macs.db since we do not have anything cached for the gateway anyway.

Reported-By: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/PVE/Network/SDN/Subnets.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/Network/SDN/Subnets.pm b/src/PVE/Network/SDN/Subnets.pm
index 8e2a6aa..05d2de2 100644
--- a/src/PVE/Network/SDN/Subnets.pm
+++ b/src/PVE/Network/SDN/Subnets.pm
@@ -399,7 +399,7 @@ sub del_ip {
 	my $plugin = PVE::Network::SDN::Ipams::Plugin->lookup($plugin_config->{type});
 	$plugin->del_ip($plugin_config, $subnetid, $subnet, $ip);
 
-	eval { PVE::Network::SDN::Ipams::del_cache_mac_ip($mac, $ip); };
+	eval { PVE::Network::SDN::Ipams::del_cache_mac_ip($mac, $ip) if $mac; };
 	warn $@ if $@;
     }
 
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH pve-network] subnets: only delete macs.db entries if mac is available
  2023-11-22 12:27 [pve-devel] [PATCH pve-network] subnets: only delete macs.db entries if mac is available Stefan Hanreich
@ 2023-11-22 13:07 ` Wolfgang Bumiller
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Bumiller @ 2023-11-22 13:07 UTC (permalink / raw)
  To: Stefan Hanreich; +Cc: pve-devel

applied, thanks




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-22 13:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-22 12:27 [pve-devel] [PATCH pve-network] subnets: only delete macs.db entries if mac is available Stefan Hanreich
2023-11-22 13:07 ` [pve-devel] applied: " Wolfgang Bumiller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal