* [pve-devel] [PATCH kernel-helper] add dedicated removable installation
@ 2023-11-21 20:19 Stoiko Ivanov
2023-11-21 20:25 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2023-11-21 20:19 UTC (permalink / raw)
To: pve-devel
seems adding `--removable` makes grub install ignore most other
information - e.g. the bootloader-id (guessed based on [0]).
add dedicated call with out `--removable` in addition
Seems that's the reason why our installer also 'rolls its own
removable' [1]
minimally tested with an ISO with this installed and an install with
ZFS on / (RAID1).
[0] https://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-install.c#n1142
[1] https://git.proxmox.com/?p=pve-installer.git;a=blob;f=Proxmox/Install.pm;h=8825699416475b1934527531db4fbb40e9473ce8;hb=HEAD#l608
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
src/bin/proxmox-boot-tool | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
index e70850a..2903ff3 100755
--- a/src/bin/proxmox-boot-tool
+++ b/src/bin/proxmox-boot-tool
@@ -161,6 +161,14 @@ init_bootloader() {
if [ -d /sys/firmware/efi ]; then
if [ -n "$mode" ] && [ "$mode" = "grub" ]; then
echo "Installing grub x86_64 target.."
+ grub-install.real \
+ --boot-directory "${esp_mp}" \
+ --target x86_64-efi \
+ --no-floppy \
+ --efi-directory "${esp_mp}" \
+ --bootloader-id 'proxmox' \
+ "/dev/$PKNAME"
+ echo "Installing grub x86_64 target (removable).."
grub-install.real \
--boot-directory "${esp_mp}" \
--target x86_64-efi \
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH kernel-helper] add dedicated removable installation
2023-11-21 20:19 [pve-devel] [PATCH kernel-helper] add dedicated removable installation Stoiko Ivanov
@ 2023-11-21 20:25 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-11-21 20:25 UTC (permalink / raw)
To: Proxmox VE development discussion, Stoiko Ivanov
Am 21/11/2023 um 21:19 schrieb Stoiko Ivanov:
> seems adding `--removable` makes grub install ignore most other
> information - e.g. the bootloader-id (guessed based on [0]).
> add dedicated call with out `--removable` in addition
>
> Seems that's the reason why our installer also 'rolls its own
> removable' [1]
>
> minimally tested with an ISO with this installed and an install with
> ZFS on / (RAID1).
>
> [0] https://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-install.c#n1142
> [1] https://git.proxmox.com/?p=pve-installer.git;a=blob;f=Proxmox/Install.pm;h=8825699416475b1934527531db4fbb40e9473ce8;hb=HEAD#l608
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/bin/proxmox-boot-tool | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>
applied, surely one cannot have enough grubs installed, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-21 20:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-21 20:19 [pve-devel] [PATCH kernel-helper] add dedicated removable installation Stoiko Ivanov
2023-11-21 20:25 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox