[pve-devel] [PATCH kernel-helper] grub-install: provide --removable to grub-install

[pve-devel] [PATCH kernel-helper] grub-install: provide --removable to grub-install

[Stoiko Ivanov]

noticed while installing with secure-boot enabled on ZFS RAID1:
The system has no entry to boot from in the efi-vars and
the entry for the first disk simply does not boot (I assume OVMF tries
the default bootx64.efi.

Since `proxmox-boot-tool init` should only be done for ESPs, which are
dedicated to proxmox products I don't think that this will cause many
regressions

For comparison - our installer has done the manual equivalent of the
--removable option for installs on ext4 for quite a while.

minimally tested on a VM during install.

Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
ftr: In Mira's tests a RAID1 install on ZFS booted fine as long as both
disks were added to the boot-options (which I cannot explain)

 src/bin/proxmox-boot-tool | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
index befa2fb..e70850a 100755
--- a/src/bin/proxmox-boot-tool
+++ b/src/bin/proxmox-boot-tool
@@ -166,6 +166,7 @@ init_bootloader() {
 				--target x86_64-efi \
 				--no-floppy \
 				--efi-directory "${esp_mp}" \
+				--removable \
 				--bootloader-id 'proxmox' \
 				"/dev/$PKNAME"
 		else
-- 
2.39.2

[pve-devel] applied: [PATCH kernel-helper] grub-install: provide --removable to grub-install

[Thomas Lamprecht]

Am 21/11/2023 um 17:56 schrieb Stoiko Ivanov:
> noticed while installing with secure-boot enabled on ZFS RAID1:
> The system has no entry to boot from in the efi-vars and
> the entry for the first disk simply does not boot (I assume OVMF tries
> the default bootx64.efi.
> 
> Since `proxmox-boot-tool init` should only be done for ESPs, which are
> dedicated to proxmox products I don't think that this will cause many
> regressions
> 
> For comparison - our installer has done the manual equivalent of the
> --removable option for installs on ext4 for quite a while.
> 
> minimally tested on a VM during install.
> 
> Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> ftr: In Mira's tests a RAID1 install on ZFS booted fine as long as both
> disks were added to the boot-options (which I cannot explain)
> 
>  src/bin/proxmox-boot-tool | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!