From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH kernel-helper] grub-install: provide --removable to grub-install
Date: Tue, 21 Nov 2023 17:56:58 +0100 [thread overview]
Message-ID: <20231121165658.1563304-1-s.ivanov@proxmox.com> (raw)
noticed while installing with secure-boot enabled on ZFS RAID1:
The system has no entry to boot from in the efi-vars and
the entry for the first disk simply does not boot (I assume OVMF tries
the default bootx64.efi.
Since `proxmox-boot-tool init` should only be done for ESPs, which are
dedicated to proxmox products I don't think that this will cause many
regressions
For comparison - our installer has done the manual equivalent of the
--removable option for installs on ext4 for quite a while.
minimally tested on a VM during install.
Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
ftr: In Mira's tests a RAID1 install on ZFS booted fine as long as both
disks were added to the boot-options (which I cannot explain)
src/bin/proxmox-boot-tool | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
index befa2fb..e70850a 100755
--- a/src/bin/proxmox-boot-tool
+++ b/src/bin/proxmox-boot-tool
@@ -166,6 +166,7 @@ init_bootloader() {
--target x86_64-efi \
--no-floppy \
--efi-directory "${esp_mp}" \
+ --removable \
--bootloader-id 'proxmox' \
"/dev/$PKNAME"
else
--
2.39.2
next reply other threads:[~2023-11-21 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 16:56 Stoiko Ivanov [this message]
2023-11-21 17:41 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121165658.1563304-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox