From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer v2 1/7] gui: move create_basic_grid subroutine definition up
Date: Tue, 21 Nov 2023 16:10:19 +0100 [thread overview]
Message-ID: <20231121151025.233224-2-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20231121151025.233224-1-m.sandoval@proxmox.com>
This will be used in future commits to create grids so we need it to be defined.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
proxinstall | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/proxinstall b/proxinstall
index 01d4cfe..8f40234 100755
--- a/proxinstall
+++ b/proxinstall
@@ -325,6 +325,21 @@ sub create_cidr_inputs {
my $ipconf_first_view = 1;
+my $create_basic_grid = sub {
+ my $grid = Gtk3::Grid->new();
+ $grid->set_visible(1);
+ $grid->set_column_spacing(10);
+ $grid->set_row_spacing(10);
+ $grid->set_hexpand(1);
+
+ $grid->set_margin_start(10);
+ $grid->set_margin_end(20);
+ $grid->set_margin_top(5);
+ $grid->set_margin_bottom(5);
+
+ return $grid;
+};
+
sub create_ipconf_view {
cleanup_view();
@@ -941,21 +956,6 @@ my $target_hd_label;
my $hdoption_first_setup = 1;
-my $create_basic_grid = sub {
- my $grid = Gtk3::Grid->new();
- $grid->set_visible(1);
- $grid->set_column_spacing(10);
- $grid->set_row_spacing(10);
- $grid->set_hexpand(1);
-
- $grid->set_margin_start(10);
- $grid->set_margin_end(20);
- $grid->set_margin_top(5);
- $grid->set_margin_bottom(5);
-
- return $grid;
-};
-
# takes an array ref of rows with [$label_text, $widget, $suffix_label] array refs as columns
# $suffix_label is optional
my $create_label_widget_grid = sub {
--
2.39.2
next prev parent reply other threads:[~2023-11-21 15:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:10 [pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible Maximiliano Sandoval
2023-11-21 15:10 ` Maximiliano Sandoval [this message]
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 2/7] gui: expand ip address Gtk3::Entry Maximiliano Sandoval
2023-12-15 12:06 ` Christoph Heiss
2023-12-15 14:08 ` Maximiliano Sandoval
2023-12-20 9:40 ` Christoph Heiss
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 3/7] gui: use basic grid in password panel Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 4/7] gui: use basic grid in country/timezone panel Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 5/7] gui: change margins in create_basic_grid Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 6/7] gui: use basic grid in the network panel Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 7/7] gui: remove trailing spaces and colons Maximiliano Sandoval
2023-12-14 13:58 ` [pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible Maximiliano Sandoval
2023-12-15 8:50 ` Lukas Wagner
2023-12-15 12:08 ` Christoph Heiss
2024-01-08 10:47 ` Maximiliano Sandoval
2024-02-14 13:32 ` Maximiliano Sandoval
2024-02-22 13:31 ` Maximiliano Sandoval
2024-02-23 13:16 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121151025.233224-2-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox