From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-widget-toolkit 4/4] notification ui: add appropriate onlineHelp anchors
Date: Tue, 21 Nov 2023 15:47:58 +0100 [thread overview]
Message-ID: <20231121144758.243333-5-l.wagner@proxmox.com> (raw)
In-Reply-To: <20231121144758.243333-1-l.wagner@proxmox.com>
This links the dialog windows to the correct help section (different
target types, matchers).
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/panel/GotifyEditPanel.js | 1 +
src/panel/NotificationConfigView.js | 1 +
src/panel/SendmailEditPanel.js | 1 +
src/panel/SmtpEditPanel.js | 1 +
src/window/NotificationMatcherEdit.js | 1 +
5 files changed, 5 insertions(+)
diff --git a/src/panel/GotifyEditPanel.js b/src/panel/GotifyEditPanel.js
index 7e6ecd8..0e8cac4 100644
--- a/src/panel/GotifyEditPanel.js
+++ b/src/panel/GotifyEditPanel.js
@@ -2,6 +2,7 @@ Ext.define('Proxmox.panel.GotifyEditPanel', {
extend: 'Proxmox.panel.InputPanel',
xtype: 'pmxGotifyEditPanel',
mixins: ['Proxmox.Mixin.CBind'],
+ onlineHelp: 'notification_targets_gotify',
type: 'gotify',
diff --git a/src/panel/NotificationConfigView.js b/src/panel/NotificationConfigView.js
index 4695da5..4d3ee46 100644
--- a/src/panel/NotificationConfigView.js
+++ b/src/panel/NotificationConfigView.js
@@ -2,6 +2,7 @@ Ext.define('Proxmox.panel.NotificationConfigView', {
extend: 'Ext.panel.Panel',
alias: 'widget.pmxNotificationConfigView',
mixins: ['Proxmox.Mixin.CBind'],
+ onlineHelp: 'chapter_notifications',
layout: {
type: 'border',
},
diff --git a/src/panel/SendmailEditPanel.js b/src/panel/SendmailEditPanel.js
index b744787..5a154c1 100644
--- a/src/panel/SendmailEditPanel.js
+++ b/src/panel/SendmailEditPanel.js
@@ -4,6 +4,7 @@ Ext.define('Proxmox.panel.SendmailEditPanel', {
mixins: ['Proxmox.Mixin.CBind'],
type: 'sendmail',
+ onlineHelp: 'notification_targets_sendmail',
mailValidator: function() {
let mailto_user = this.down(`[name=mailto-user]`);
diff --git a/src/panel/SmtpEditPanel.js b/src/panel/SmtpEditPanel.js
index 218485d..8b258e0 100644
--- a/src/panel/SmtpEditPanel.js
+++ b/src/panel/SmtpEditPanel.js
@@ -2,6 +2,7 @@ Ext.define('Proxmox.panel.SmtpEditPanel', {
extend: 'Proxmox.panel.InputPanel',
xtype: 'pmxSmtpEditPanel',
mixins: ['Proxmox.Mixin.CBind'],
+ onlineHelp: 'notification_targets_smtp',
type: 'smtp',
diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js
index ee08c16..9ee34fd 100644
--- a/src/window/NotificationMatcherEdit.js
+++ b/src/window/NotificationMatcherEdit.js
@@ -73,6 +73,7 @@ Ext.define('Proxmox.window.NotificationMatcherEdit', {
extend: 'Proxmox.window.Edit',
isAdd: true,
+ onlineHelp: 'notification_matchers',
fieldDefaults: {
labelWidth: 120,
--
2.39.2
next prev parent reply other threads:[~2023-11-21 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 14:47 [pve-devel] [PATCH docs/manager/proxmox-widget-toolkit 0/4] notifications: add help buttons, linking to the appropriate sections Lukas Wagner
2023-11-21 14:47 ` [pve-devel] [PATCH pve-docs 1/4] notification: add anchors for target types/matchers Lukas Wagner
2023-11-21 16:37 ` [pve-devel] applied: " Thomas Lamprecht
2023-11-21 14:47 ` [pve-devel] [PATCH pve-manager 2/4] ui: sdn: fix onlineHelp anchors Lukas Wagner
2023-11-21 16:37 ` Thomas Lamprecht
2023-11-21 14:47 ` [pve-devel] [PATCH pve-manager 3/4] ui: dc: config: remove onlineHelp for notification config view Lukas Wagner
2023-11-21 16:38 ` [pve-devel] applied: " Thomas Lamprecht
2023-11-21 14:47 ` Lukas Wagner [this message]
2023-11-21 19:52 ` [pve-devel] applied: [PATCH proxmox-widget-toolkit 4/4] notification ui: add appropriate onlineHelp anchors Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121144758.243333-5-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox