From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-network 2/2] sdn: simple: Improve dhcp property description and validation
Date: Tue, 21 Nov 2023 14:31:04 +0100 [thread overview]
Message-ID: <20231121133104.278628-2-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20231121133104.278628-1-s.hanreich@proxmox.com>
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
src/PVE/Network/SDN/Zones/SimplePlugin.pm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Zones/SimplePlugin.pm b/src/PVE/Network/SDN/Zones/SimplePlugin.pm
index f4525d5..7cb65c2 100644
--- a/src/PVE/Network/SDN/Zones/SimplePlugin.pm
+++ b/src/PVE/Network/SDN/Zones/SimplePlugin.pm
@@ -3,6 +3,7 @@ package PVE::Network::SDN::Zones::SimplePlugin;
use strict;
use warnings;
use PVE::Network::SDN::Zones::Plugin;
+use PVE::Network::SDN::Dhcp::Plugin;
use PVE::Exception qw(raise raise_param_exc);
use PVE::Cluster;
use PVE::Tools;
@@ -28,8 +29,9 @@ sub properties {
description => "dns domain zone ex: mydomain.com",
},
dhcp => {
- type => 'pve-configid',
- description => 'ID of the DHCP server responsible for managing this range',
+ description => 'Type of the DHCP backend for this zone',
+ type => 'string',
+ enum => PVE::Network::SDN::Dhcp::Plugin->lookup_types(),
requires => 'ipam',
},
};
--
2.39.2
next prev parent reply other threads:[~2023-11-21 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 13:31 [pve-devel] [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp Stefan Hanreich
2023-11-21 13:31 ` Stefan Hanreich [this message]
2023-11-21 13:47 ` [pve-devel] applied-series: " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121133104.278628-2-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox