[pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage

[pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage

[Christian Ebner]

SI units are used for storage size information, as typically used by
hard disk manufacturers.

Change the root filesystem usage values in the node summary to be
consistent.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---

Will also send a patch for PMG to be consistent across all of them.

changes since v1:
- use more compact renderer invocation, same as used in PBS

 www/manager6/node/StatusView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js
index d34724f7..f6cd42ad 100644
--- a/www/manager6/node/StatusView.js
+++ b/www/manager6/node/StatusView.js
@@ -72,7 +72,7 @@ Ext.define('PVE.node.StatusView', {
 	    title: '/ ' + gettext('HD space'),
 	    valueField: 'rootfs',
 	    maxField: 'rootfs',
-	    renderer: Proxmox.Utils.render_node_size_usage,
+	    renderer: ({ used, total }) => Proxmox.Utils.render_size_usage(used, total, true),
 	},
 	{
 	    iconCls: 'fa fa-fw fa-refresh',
-- 
2.39.2

Re: [pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage

[Philipp Hufnagl]

On 11/21/23 12:36, Christian Ebner wrote:
> SI units are used for storage size information, as typically used by
> hard disk manufacturers.
> 
> Change the root filesystem usage values in the node summary to be
> consistent.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> 
> Will also send a patch for PMG to be consistent across all of them.
> 
> changes since v1:
> - use more compact renderer invocation, same as used in PBS
> 
>  www/manager6/node/StatusView.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js
> index d34724f7..f6cd42ad 100644
> --- a/www/manager6/node/StatusView.js
> +++ b/www/manager6/node/StatusView.js
> @@ -72,7 +72,7 @@ Ext.define('PVE.node.StatusView', {
>  	    title: '/ ' + gettext('HD space'),
>  	    valueField: 'rootfs',
>  	    maxField: 'rootfs',
> -	    renderer: Proxmox.Utils.render_node_size_usage,
> +	    renderer: ({ used, total }) => Proxmox.Utils.render_size_usage(used, total, true),
>  	},
>  	{
>  	    iconCls: 'fa fa-fw fa-refresh',

LGTM

Tested-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
Reviewed-by: Philipp Hufnagl <p.hufangl@proxmox.com>