From: Christian Ebner <c.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage
Date: Tue, 21 Nov 2023 12:36:57 +0100 [thread overview]
Message-ID: <20231121113657.194610-1-c.ebner@proxmox.com> (raw)
SI units are used for storage size information, as typically used by
hard disk manufacturers.
Change the root filesystem usage values in the node summary to be
consistent.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Will also send a patch for PMG to be consistent across all of them.
changes since v1:
- use more compact renderer invocation, same as used in PBS
www/manager6/node/StatusView.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js
index d34724f7..f6cd42ad 100644
--- a/www/manager6/node/StatusView.js
+++ b/www/manager6/node/StatusView.js
@@ -72,7 +72,7 @@ Ext.define('PVE.node.StatusView', {
title: '/ ' + gettext('HD space'),
valueField: 'rootfs',
maxField: 'rootfs',
- renderer: Proxmox.Utils.render_node_size_usage,
+ renderer: ({ used, total }) => Proxmox.Utils.render_size_usage(used, total, true),
},
{
iconCls: 'fa fa-fw fa-refresh',
--
2.39.2
next reply other threads:[~2023-11-21 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 11:36 Christian Ebner [this message]
2023-11-21 11:45 ` Philipp Hufnagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121113657.194610-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox