From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter
Date: Tue, 21 Nov 2023 11:22:04 +0100 [thread overview]
Message-ID: <20231121102208.82219-1-l.wagner@proxmox.com> (raw)
This patch series adds the 'notification-mode' setting for backup jobs.
It allows users to choose between the 'old-style' notifications
(mail to configured address, directly via a call to sendmail) or
the 'new-style' notification system.
notification-mode has three possible values:
- legacy-sendmail: Use old system, considering mailto/mailtnotification parameters
- notification-system: Use the new system (always sending a notification, irregardless
of success/failure. The user is supposed to configure filtering/matching in
notification settings)
- auto: use old system if mailto is set, or new system if not
This should provide a fix/workaround for the users' reports of
- double notifications (these happened in case mailto was set to the same address
as root@pam)
- notifications always being sent, even if 'mailnotification' is set to failure
pve-guest-common:
Lukas Wagner (1):
vzdump: config: add 'notification-mode' param for backup jobs
src/PVE/VZDump/Common.pm | 14 ++++++++++++++
1 file changed, 14 insertions(+)
pve-manager:
Lukas Wagner (3):
vzdump: support 'notification-mode' parameter
ui: backup jobs: add 'notification-mode' selector for backup jobs
ui: backup: add 'notification-mode' param for one-shot backup jobs.
PVE/VZDump.pm | 95 +++++++++++++++++++++--------------
www/manager6/dc/Backup.js | 33 +++++++++++-
www/manager6/window/Backup.js | 25 +++++++++
3 files changed, 115 insertions(+), 38 deletions(-)
Summary over all repositories:
4 files changed, 129 insertions(+), 38 deletions(-)
--
murpp v0.4.0
next reply other threads:[~2023-11-21 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 10:22 Lukas Wagner [this message]
2023-11-21 10:22 ` [pve-devel] [PATCH v2 pve-guest-common 1/4] vzdump: config: add 'notification-mode' param for backup jobs Lukas Wagner
2023-11-21 12:32 ` [pve-devel] applied: " Thomas Lamprecht
2023-11-21 10:22 ` [pve-devel] [PATCH v2 pve-manager 2/4] vzdump: support 'notification-mode' parameter Lukas Wagner
2023-11-21 10:22 ` [pve-devel] [PATCH v2 pve-manager 3/4] ui: backup jobs: add 'notification-mode' selector for backup jobs Lukas Wagner
2023-11-21 10:22 ` [pve-devel] [PATCH v2 pve-manager 4/4] ui: backup: add 'notification-mode' param for one-shot " Lukas Wagner
2023-11-21 10:23 ` [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter Lukas Wagner
2023-11-21 10:55 ` Fiona Ebner
2023-11-21 12:13 ` Lukas Wagner
2023-11-21 12:34 ` Fiona Ebner
2023-11-21 12:34 ` Thomas Lamprecht
2023-11-21 12:29 ` Philipp Hufnagl
2023-11-21 12:32 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121102208.82219-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox