public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container] setup: nixos: set cmode to console by default
Date: Tue, 21 Nov 2023 10:40:58 +0100	[thread overview]
Message-ID: <20231121094230.309931-1-c.heiss@proxmox.com> (raw)

In the default NixOS configuration (e.g. when using prebuilt container
images from the Hydra pipeline [0]), getty is only configured for
/dev/console, but not any TTY ports. This results in the user just
getting a blank, black screen when opening the console in the web UI.

With this, the mentioned tarballs [0] work out-of-the-box.

[0] https://hydra.nixos.org/job/nixos/trunk-combined/nixos.containerTarball.x86_64-linux

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 src/PVE/LXC/Setup/NixOS.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/PVE/LXC/Setup/NixOS.pm b/src/PVE/LXC/Setup/NixOS.pm
index c702f3d..7f23111 100644
--- a/src/PVE/LXC/Setup/NixOS.pm
+++ b/src/PVE/LXC/Setup/NixOS.pm
@@ -17,6 +17,11 @@ sub new {

     $conf->{ostype} = "nixos";

+    # Set `cmode` to `console` for NixOS containers, as getty is only configured for /dev/console by
+    # default, but not any TTY ports. This way, users still get a login/shell instead of just a
+    # blank screen when openinng the console in the web UI.
+    $conf->{cmode} = 'console';
+
     return bless $self, $class;
 }

--
2.42.0





             reply	other threads:[~2023-11-21  9:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21  9:40 Christoph Heiss [this message]
2024-01-26 14:47 ` Fiona Ebner
2024-02-14 13:04   ` Christoph Heiss
2024-02-14 14:03     ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231121094230.309931-1-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal