[pve-devel] [PATCH manager] ui: fix zero-sized panels on fresh chrome start

[pve-devel] [PATCH manager] ui: fix zero-sized panels on fresh chrome start

[Dominik Csapak]

it seems in new versions of chrome , this triggers too early on a fresh
start (when autostarting a pve tab), resulting in the
'viewWidth'/'viewHeight' being zero pixels. This means we set the width
of the left and the height of the bottom panel to zero pixels, making
them functionally invisible.

To prevent that, check that the 'viewWidth'/'viewHeight' is big enough
so that the panels still have least 50 pixels left before setting their
size.

reported on the pve-user list:
https://lists.proxmox.com/pipermail/pve-user/2023-November/017292.html

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
this plaged me for at least a week, but it seems no one else ran into
this, so i blamed my local install, until the report on pve-user

we should probably backport this to stable-7, can send a separate fix
should it not cleanly apply/be cherry-pickable

 www/manager6/Workspace.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 6e465f8d..89ca47b7 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -485,7 +485,7 @@ Ext.define('PVE.StdWorkspace', {
 		    listeners: {
 			resize: function(panel, width, height) {
 			    var viewWidth = me.getSize().width;
-			    if (width > viewWidth - 100) {
+			    if (width > viewWidth - 100 && viewWidth > 150) {
 				panel.setWidth(viewWidth - 100);
 			    }
 			},
@@ -506,7 +506,7 @@ Ext.define('PVE.StdWorkspace', {
 		    listeners: {
 			resize: function(panel, width, height) {
 			    var viewHeight = me.getSize().height;
-			    if (height > viewHeight - 150) {
+			    if (height > viewHeight - 150 && viewHeight > 200) {
 				panel.setHeight(viewHeight - 150);
 			    }
 			},
-- 
2.30.2

Re: [pve-devel] [PATCH manager] ui: fix zero-sized panels on fresh chrome start

[Dominik Csapak]

On 11/20/23 09:02, Dominik Csapak wrote:
> it seems in new versions of chrome , this triggers too early on a fresh
> start (when autostarting a pve tab), resulting in the
> 'viewWidth'/'viewHeight' being zero pixels. This means we set the width
> of the left and the height of the bottom panel to zero pixels, making
> them functionally invisible.
> 
> To prevent that, check that the 'viewWidth'/'viewHeight' is big enough
> so that the panels still have least 50 pixels left before setting their
> size.
> 
> reported on the pve-user list:
> https://lists.proxmox.com/pipermail/pve-user/2023-November/017292.html


this actually is a different issue, i misunderstood the message
from the user...

anyway it's a problem i can reproduce here quite easily, so
i guess somebody else will trigger it sooner or later

> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this plaged me for at least a week, but it seems no one else ran into
> this, so i blamed my local install, until the report on pve-user
> 
> we should probably backport this to stable-7, can send a separate fix
> should it not cleanly apply/be cherry-pickable
> 
>   www/manager6/Workspace.js | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
> index 6e465f8d..89ca47b7 100644
> --- a/www/manager6/Workspace.js
> +++ b/www/manager6/Workspace.js
> @@ -485,7 +485,7 @@ Ext.define('PVE.StdWorkspace', {
>   		    listeners: {
>   			resize: function(panel, width, height) {
>   			    var viewWidth = me.getSize().width;
> -			    if (width > viewWidth - 100) {
> +			    if (width > viewWidth - 100 && viewWidth > 150) {
>   				panel.setWidth(viewWidth - 100);
>   			    }
>   			},
> @@ -506,7 +506,7 @@ Ext.define('PVE.StdWorkspace', {
>   		    listeners: {
>   			resize: function(panel, width, height) {
>   			    var viewHeight = me.getSize().height;
> -			    if (height > viewHeight - 150) {
> +			    if (height > viewHeight - 150 && viewHeight > 200) {
>   				panel.setHeight(viewHeight - 150);
>   			    }
>   			},

Re: [pve-devel] [PATCH manager] ui: fix zero-sized panels on fresh chrome start

[Thomas Lamprecht]

Am 20/11/2023 um 09:07 schrieb Dominik Csapak:
> On 11/20/23 09:02, Dominik Csapak wrote:
>> it seems in new versions of chrome , this triggers too early on a fresh
>> start (when autostarting a pve tab), resulting in the
>> 'viewWidth'/'viewHeight' being zero pixels. This means we set the width
>> of the left and the height of the bottom panel to zero pixels, making
>> them functionally invisible.
>>
>> To prevent that, check that the 'viewWidth'/'viewHeight' is big enough
>> so that the panels still have least 50 pixels left before setting their
>> size.
>>
>> reported on the pve-user list:
>> https://lists.proxmox.com/pipermail/pve-user/2023-November/017292.html
> 
> this actually is a different issue, i misunderstood the message
> from the user...
> 
> anyway it's a problem i can reproduce here quite easily, so

Is this related to:
https://forum.proxmox.com/threads/web-portal-rendering-issues-vivaldi-brower.136636/#post-606233
?

Re: [pve-devel] [PATCH manager] ui: fix zero-sized panels on fresh chrome start

[Dominik Csapak]

On 11/20/23 09:26, Thomas Lamprecht wrote:
> Am 20/11/2023 um 09:07 schrieb Dominik Csapak:
>> On 11/20/23 09:02, Dominik Csapak wrote:
>>> it seems in new versions of chrome , this triggers too early on a fresh
>>> start (when autostarting a pve tab), resulting in the
>>> 'viewWidth'/'viewHeight' being zero pixels. This means we set the width
>>> of the left and the height of the bottom panel to zero pixels, making
>>> them functionally invisible.
>>>
>>> To prevent that, check that the 'viewWidth'/'viewHeight' is big enough
>>> so that the panels still have least 50 pixels left before setting their
>>> size.
>>>
>>> reported on the pve-user list:
>>> https://lists.proxmox.com/pipermail/pve-user/2023-November/017292.html
>>
>> this actually is a different issue, i misunderstood the message
>> from the user...
>>
>> anyway it's a problem i can reproduce here quite easily, so
> 
> Is this related to:
> https://forum.proxmox.com/threads/web-portal-rendering-issues-vivaldi-brower.136636/#post-606233
> ?

yes it seems to be the same issue

[pve-devel] applied: [PATCH manager] ui: fix zero-sized panels on fresh chrome start

[Thomas Lamprecht]

Am 20/11/2023 um 09:02 schrieb Dominik Csapak:
> it seems in new versions of chrome , this triggers too early on a fresh
> start (when autostarting a pve tab), resulting in the
> 'viewWidth'/'viewHeight' being zero pixels. This means we set the width
> of the left and the height of the bottom panel to zero pixels, making
> them functionally invisible.
> 
> To prevent that, check that the 'viewWidth'/'viewHeight' is big enough
> so that the panels still have least 50 pixels left before setting their
> size.
> 
> reported on the pve-user list:
> https://lists.proxmox.com/pipermail/pve-user/2023-November/017292.html
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this plaged me for at least a week, but it seems no one else ran into
> this, so i blamed my local install, until the report on pve-user
> 
> we should probably backport this to stable-7, can send a separate fix
> should it not cleanly apply/be cherry-pickable
> 
>  www/manager6/Workspace.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, with the link swapped out to the one that's actually a report about
this issue in the forum, thanks!