From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC PATCH installer 1/2] ui: stdio: replace newlines with whitespaces in prompt messages
Date: Fri, 17 Nov 2023 14:45:26 +0100 [thread overview]
Message-ID: <20231117134700.701332-1-c.heiss@proxmox.com> (raw)
The line-based protocol currently used cannot handle this properly, so
introduce this as a stop-gap measure - otherwise messages might be cut
off.
This makes it work for now, and the text is wrapped correctely for the
screen width in the TUI anyway - which is the only user of this so far.
Will be reworked properly later on.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Proxmox/UI/StdIO.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/Proxmox/UI/StdIO.pm b/Proxmox/UI/StdIO.pm
index 0ee6311..f734c0b 100644
--- a/Proxmox/UI/StdIO.pm
+++ b/Proxmox/UI/StdIO.pm
@@ -36,6 +36,7 @@ sub finished {
sub prompt {
my ($self, $query) = @_;
+ $query =~ s/\n/ /g;
print STDOUT "prompt: $query\n";
my $response = <STDIN> // ''; # FIXME: error handling?
--
2.42.0
next reply other threads:[~2023-11-17 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 13:45 Christoph Heiss [this message]
2023-11-17 13:45 ` [pve-devel] [PATCH installer 2/2] tui: install progress: use ok/cancel as button text for installer prompt Christoph Heiss
2023-11-17 16:09 ` [pve-devel] applied: [RFC PATCH installer 1/2] ui: stdio: replace newlines with whitespaces in prompt messages Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117134700.701332-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox