public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH installer 3/4] fix #1410: zfs: create /var/lib/vz as separate dataset
Date: Thu, 16 Nov 2023 17:31:47 +0100	[thread overview]
Message-ID: <20231116173147.5ac9e887@rosa.proxmox.com> (raw)
In-Reply-To: <20231116150041.1089432-4-s.ivanov@proxmox.com>

this is wrong!
the dataset is only needed for pve
I'll resend a v2

sorry for the noise!


On Thu, 16 Nov 2023 16:00:40 +0100
Stoiko Ivanov <s.ivanov@proxmox.com> wrote:

> this enables the users to set reservations on / separate from
> /var/lib/vz - where backups, ISOs, and other data might fill the
> complete pool.
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  Proxmox/Install.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
> index c868992..a96249e 100644
> --- a/Proxmox/Install.pm
> +++ b/Proxmox/Install.pm
> @@ -189,6 +189,9 @@ sub zfs_create_rpool {
>      syscmd("zfs create $pool_name/ROOT/$root_volume_name")  == 0 ||
>  	die "unable to create zfs $pool_name/ROOT/$root_volume_name volume\n";
>  
> +    syscmd("zfs create -p $pool_name/ROOT/$root_volume_name/var/lib/vz")  == 0 ||
> +	die "unable to create zfs $pool_name/ROOT/$root_volume_name/var/lib/vz volume\n";
> +
>      # default to `relatime` on, fast enough for the installer and production
>      syscmd("zfs set atime=on relatime=on $pool_name") == 0 || die "unable to set zfs properties\n";
>  





  reply	other threads:[~2023-11-16 16:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 15:00 [pve-devel] [PATCH installer 0/4] adaptation to kernel cmdline handling and 2 small ZFS related improvements Stoiko Ivanov
2023-11-16 15:00 ` [pve-devel] [PATCH installer 1/4] fix #4747: pass kernel cmdline parameters to target system Stoiko Ivanov
2023-11-16 15:00 ` [pve-devel] [PATCH installer 2/4] unconfigured.sh: set serial to a number to prevent warning Stoiko Ivanov
2023-11-16 15:00 ` [pve-devel] [PATCH installer 3/4] fix #1410: zfs: create /var/lib/vz as separate dataset Stoiko Ivanov
2023-11-16 16:31   ` Stoiko Ivanov [this message]
2023-11-16 15:00 ` [pve-devel] [PATCH installer 4/4] zfs: set acltype=posix for root-dataset Stoiko Ivanov
2023-11-16 16:46 ` [pve-devel] applied-series: [PATCH installer 0/4] adaptation to kernel cmdline handling and 2 small ZFS related improvements Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231116173147.5ac9e887@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal